From patchwork Mon Jul 18 12:40:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 105256 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 967A1B6F71 for ; Mon, 18 Jul 2011 22:40:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755241Ab1GRMkj (ORCPT ); Mon, 18 Jul 2011 08:40:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40059 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab1GRMki (ORCPT ); Mon, 18 Jul 2011 08:40:38 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id B93748ADF6; Mon, 18 Jul 2011 14:40:37 +0200 (CEST) From: Jean Delvare Organization: Suse Linux To: netdev@vger.kernel.org Subject: [PATCH] tulip: Disable debugging messages by default Date: Mon, 18 Jul 2011 14:40:35 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.32.36-0.5-pae; KDE/4.3.5; i686; ; ) Cc: Grant Grundler , Joe Perches MIME-Version: 1.0 Message-Id: <201107181440.35886.jdelvare@suse.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With debugging messages enabled by default, one user complained [1] that his log was spammed with these messages: [ 6233.528227] dmfe: tdes0=7fff0000 [ 6237.651056] dmfe: tdes0=7fff0000 [ 6237.651060] dmfe: tdes0=7fff0000 [ 6237.696019] dmfe: tdes0=7fff0000 [ 6237.696022] dmfe: tdes0=7fff0000 [ 6238.028810] dmfe: tdes0=7fff0000 [ 6238.028814] dmfe: tdes0=7fff0000 [ 6238.073544] dmfe: tdes0=7fff0000 [ 6238.073547] dmfe: tdes0=7fff0000 With dynamic debugging available, I think it makes no sense to enable debugging messages by default, especially for such old drivers which aren't been actively developed any longer. [1] http://lists.opensuse.org/opensuse-kernel/2011-07/msg00060.html Signed-off-by: Jean Delvare Cc: Grant Grundler Cc: Joe Perches --- drivers/net/tulip/Makefile | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/tulip/Makefile +++ b/drivers/net/tulip/Makefile @@ -2,8 +2,6 @@ # Makefile for the Linux "Tulip" family network device drivers. # -ccflags-$(CONFIG_NET_TULIP) := -DDEBUG - obj-$(CONFIG_PCMCIA_XIRCOM) += xircom_cb.o obj-$(CONFIG_DM9102) += dmfe.o obj-$(CONFIG_WINBOND_840) += winbond-840.o