From patchwork Wed Jun 29 06:29:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 102519 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F30F2B6F7F for ; Wed, 29 Jun 2011 16:31:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766Ab1F2Gay (ORCPT ); Wed, 29 Jun 2011 02:30:54 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:46791 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974Ab1F2Gax (ORCPT ); Wed, 29 Jun 2011 02:30:53 -0400 Received: by pvg12 with SMTP id 12so565545pvg.19 for ; Tue, 28 Jun 2011 23:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=KwK1M3jJ8fl2aJuLy9cbmSJeJ2IwwM86yTawxE71LwQ=; b=BPETCmYiF5hsWVyXRRrCsEwzjKz6TD0FJ3AAzVpiY4/u6nn8BrstONZXoqgehwQRr0 4iV+P0shPK8WUHre0E+EW1gu3lPN7r/uFn+1Sd0cllPnQvC2FnN7eT4cuxj4vrIMH2C2 rpa8rmm+swAK0kKJ6jiL0YWb5WE7TNR7NQmgE= Received: by 10.68.22.72 with SMTP id b8mr655299pbf.293.1309329052416; Tue, 28 Jun 2011 23:30:52 -0700 (PDT) Received: from shale.localdomain ([41.139.221.94]) by mx.google.com with ESMTPS id n8sm696231pbh.89.2011.06.28.23.30.48 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 28 Jun 2011 23:30:51 -0700 (PDT) Date: Wed, 29 Jun 2011 09:29:51 +0300 From: Dan Carpenter To: Krzysztof Halasa Cc: "open list:NETWORKING DRIVERS" , kernel-janitors@vger.kernel.org Subject: [patch] wanxl: remove a stray irq enable Message-ID: <20110629062951.GD14591@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is error path calls unlock_irq() where we haven't disabled the IRQs. The comment says that this error path can never happen. Signed-off-by: Dan Carpenter --- This is a static checker fix and I don't have the hardware to test. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 8d7aa43..44b7071 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -284,7 +284,7 @@ static netdev_tx_t wanxl_xmit(struct sk_buff *skb, struct net_device *dev) printk(KERN_DEBUG "%s: transmitter buffer full\n", dev->name); #endif netif_stop_queue(dev); - spin_unlock_irq(&port->lock); + spin_unlock(&port->lock); return NETDEV_TX_BUSY; /* request packet to be queued */ }