From patchwork Thu Jun 23 05:56:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 101585 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 89BF7B6F74 for ; Thu, 23 Jun 2011 15:57:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130Ab1FWF5Z (ORCPT ); Thu, 23 Jun 2011 01:57:25 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:52661 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582Ab1FWF5Y (ORCPT ); Thu, 23 Jun 2011 01:57:24 -0400 Received: by pvg12 with SMTP id 12so945335pvg.19 for ; Wed, 22 Jun 2011 22:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=3IGZh5ui48r1WHfQ/+e5l8eFZ0lf8DWOm0phMrPcPHA=; b=w1cbGLaYdcBigaaueys2KMVRKSOagfweAOaPkGFQunjL5LlFvT2lUuwmD3bGAuQpxG DbcsjoVOmgk3KIxllqt2+1CIbOJD6SOC97BCjcSwwptTYlFoeL0x+96R69VouX+2UQtj Z34lZ1m+K+NzqopRc7Mn/2oOlhX4t6iognjDM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=RvgR+tvp342GwwNrV/Sljy1JP52N+0MMGkcpSqnr5xpryFsVfGAZNlZ+P32Svs+pZt uu6Ll/AUSfHH87qQXIlUSAyGEbwppHQv2W4qDWEKpvxXeq8hmh+uG9ZD2jxosrOF+y8Y F51Z+xxlw+dMSme84lGVTLIBBaLUFH2MNsyao= Received: by 10.68.27.100 with SMTP id s4mr951963pbg.491.1308808643665; Wed, 22 Jun 2011 22:57:23 -0700 (PDT) Received: from shale.localdomain ([41.139.221.94]) by mx.google.com with ESMTPS id p5sm977211pbd.76.2011.06.22.22.57.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2011 22:57:22 -0700 (PDT) Date: Thu, 23 Jun 2011 08:56:37 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: "open list:USB SUBSYSTEM" , "open list:NETWORKING DRIVERS" , kernel-janitors@vger.kernel.org Subject: [patch] net/usb/kalmia: signedness bug in kalmia_bind() Message-ID: <20110623055637.GL14591@shale.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org "status" should be an int here for the error handling to work. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c index d965fb1..c08fecf 100644 --- a/drivers/net/usb/kalmia.c +++ b/drivers/net/usb/kalmia.c @@ -127,7 +127,7 @@ kalmia_init_and_get_ethernet_addr(struct usbnet *dev, u8 *ethernet_addr) static int kalmia_bind(struct usbnet *dev, struct usb_interface *intf) { - u8 status; + int status; u8 ethernet_addr[ETH_ALEN]; /* Don't bind to AT command interface */