| Message ID | 20110414160717.32251.81326.sendpatchset@krkumar2.in.ibm.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
diff -ruNp org/net/8021q/vlan_dev.c new2/net/8021q/vlan_dev.c --- org/net/8021q/vlan_dev.c 2011-04-14 20:42:56.000000000 +0530 +++ new2/net/8021q/vlan_dev.c 2011-04-14 20:44:35.000000000 +0530 @@ -525,7 +525,8 @@ static int vlan_dev_init(struct net_devi /* IFF_BROADCAST|IFF_MULTICAST; ??? */ dev->flags = real_dev->flags & ~(IFF_UP | IFF_PROMISC | IFF_ALLMULTI | - IFF_MASTER | IFF_SLAVE); + IFF_MASTER | IFF_SLAVE | + IFF_LOOPBACK); dev->iflink = real_dev->ifindex; dev->state = (real_dev->state & ((1<<__LINK_STATE_NOCARRIER) | (1<<__LINK_STATE_DORMANT))) |
I have tested two ways of fixing this panic: 1. PATCH1: Do not allow vlan on lo. 2. PATCH2: Do not propagate LOOPBACK to vlan devices. Isn't it better to use PATCH1 and disallow vlan on lo? The result of this patch is: # modprobe 8021q # vconfig add lo 43 # ifconfig lo.69 hw ether 00:80:48:BA:d1:30 # ping6 -c 3 fe80::280:48ff:feba:d130 connect: Cannot assign requested address (no panic) Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com> --- net/8021q/vlan_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html