From patchwork Mon Mar 7 19:44:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Narendra K X-Patchwork-Id: 85792 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F3883B70F7 for ; Tue, 8 Mar 2011 06:45:11 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755827Ab1CGTpD (ORCPT ); Mon, 7 Mar 2011 14:45:03 -0500 Received: from ausc60ps301.us.dell.com ([143.166.148.206]:24381 "EHLO ausc60ps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab1CGTpB (ORCPT ); Mon, 7 Mar 2011 14:45:01 -0500 X-Loopcount0: from 10.175.216.250 From: To: , CC: , , , , , , , , , Date: Mon, 7 Mar 2011 11:44:52 -0800 Subject: Re: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Thread-Topic: [PATCH V4] Export ACPI _DSM provided firmware instance number and string name to sysfs Thread-Index: AcvdACA6bhW32AjyRhOlJpPR9vX+Kg== Message-ID: <20110307200512.GA22450@fedora14-r610.oslab.blr.amer.dell.com> References: <20110223125741.GA16473@fedora14-r610.blr.amer.dell.com> <20110302172508.GA2794@fedora14-r610.oslab.blr.amer.dell.com> <20110304104314.26265021@jbarnes-desktop> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.5.21 (2010-09-15) acceptlanguage: en-US MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 07, 2011 at 11:34:05PM +0530, Alexander Beregalov wrote: > On 4 March 2011 21:43, Jesse Barnes wrote: > > On Wed, 2 Mar 2011 22:34:17 +0530 > > wrote: > > > >> On Wed, Feb 23, 2011 at 06:06:42PM +0530, K, Narendra wrote: > >> > Hello, > >> > > >> > This patch exports ACPI _DSM provided firmware instance number and > >> > string name to sysfs. > >> > > >> > V1 -> V2: > >> > The attribute 'index' is changed to 'acpi_index' as the semantics of > >> > SMBIOS provided device type instance and ACPI _DSM provided firmware > >> > instance number are different. > >> > > >> > V2 -> V3: > >> > Matthew Garrett pointed out that 'sysfs_create_groups' does return an > >> > error when there are no ACPI _DSM attributes available and because of > >> > that the fallback to SMBIOS will not happen. As a result SMBIOS provided > >> > attributes are not created. This version of the patch addresses the issue. > >> > > >> > >> V3 -> V4: > >> Select NLS if (DMI || ACPI) in drivers/pci/Kconfig to prevent build > >> breakage from an 'allmodconfig' > > > > Applied, fingers crossed this time. :) > > > > Hi, > > It cannot be compiled if CONFIG_ACPI is not set. > > drivers/pci/pci-label.c: In function 'pci_create_firmware_label_files': > drivers/pci/pci-label.c:366:2: error: implicit declaration of function > 'device_has_dsm' Hello, Sorry for the inconvenience. Please find the fix here - From: Narendra K Subject: [PATCH] Fix compilation error when CONFIG_ACPI unset This patch fixes compilation error descibed below introduced by the commit 6058989bad05b82e78baacce69ec14f27a11b5fd drivers/pci/pci-label.c: In function ‘pci_create_firmware_label_files’: drivers/pci/pci-label.c:366:2: error: implicit declaration of function ‘device_has_dsm’ Signed-off-by: Narendra K --- drivers/pci/pci-label.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) -- 1.7.3.1 With regards, Narendra K diff --git a/drivers/pci/pci-label.c b/drivers/pci/pci-label.c index 824e247..82fd73d 100644 --- a/drivers/pci/pci-label.c +++ b/drivers/pci/pci-label.c @@ -29,7 +29,9 @@ #include #include #include +#ifdef CONFIG_ACPI #include +#endif #include #include "pci.h" @@ -174,6 +176,12 @@ pci_remove_acpi_index_label_files(struct pci_dev *pdev) return -1; } +static inline bool +device_has_dsm(struct device *dev) +{ + return false; +} + #else static const char device_label_dsm_uuid[] = {