From patchwork Sat Dec 25 22:23:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 76705 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46273B70E9 for ; Sun, 26 Dec 2010 09:24:03 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532Ab0LYWX6 (ORCPT ); Sat, 25 Dec 2010 17:23:58 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:37603 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103Ab0LYWX5 (ORCPT ); Sat, 25 Dec 2010 17:23:57 -0500 Received: by wyb28 with SMTP id 28so7656952wyb.19 for ; Sat, 25 Dec 2010 14:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=BoYfhZ6FvQeAnZNvcJtjpSJdd6yFGoB9MQQEdSJim3U=; b=EJ9pXb/lo7WCZ4v4YB+nLi7i3iOFO0elWcpRylpcYYL//u6IQULbZH8OXZPPVYjjRv Mcd/QPsaQiTYwb213yJkab5ejhntb/0Ths0FZDmM0JdhV06ZxQDBlN6F6TXFCIgME3IW KAF+kn5g2Qs3MLLFMQfGvqPcsNTDM1qWVqpSA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=UNtEtXLhOLrsi1pkdxHox6Aw4yCUOHMnYqOhMBtxB+NW0DU1iu8Rdrw7CnEGiwZCNP XhRJJsSeFoPV1yTT86fNb+fa3xobqivV50qNo9mG+D9P9cUmQx+vmXeYNsG02y78AjbR 7orQfPnarkd7Bt89yKu7Udb6K/usYrW6CGZHE= Received: by 10.216.18.194 with SMTP id l44mr15279689wel.87.1293315835428; Sat, 25 Dec 2010 14:23:55 -0800 (PST) Received: from bicker ([41.202.225.147]) by mx.google.com with ESMTPS id f52sm5072041wes.11.2010.12.25.14.23.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 25 Dec 2010 14:23:54 -0800 (PST) Date: Sun, 26 Dec 2010 01:23:42 +0300 From: Dan Carpenter To: Oliver Neukum Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] USB: cdc_ether: remove unneeded check Message-ID: <20101225222341.GS1936@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We already verified that "dev->udev->actconfig->extralen" was non-zero so "len" is non-zero here as well. Signed-off-by: Dan Carpenter Acked-by: Oliver Neukum --- Compile tested. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index b3fe0de..9a60e41 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -99,9 +99,7 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf) */ buf = dev->udev->actconfig->extra; len = dev->udev->actconfig->extralen; - if (len) - dev_dbg(&intf->dev, - "CDC descriptors on config\n"); + dev_dbg(&intf->dev, "CDC descriptors on config\n"); } /* Maybe CDC descriptors are after the endpoint? This bug has