From patchwork Mon Dec 20 13:00:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 76204 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 84710B6F14 for ; Tue, 21 Dec 2010 00:00:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757519Ab0LTNAj (ORCPT ); Mon, 20 Dec 2010 08:00:39 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:48503 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750Ab0LTNAi (ORCPT ); Mon, 20 Dec 2010 08:00:38 -0500 Received: by wwa36 with SMTP id 36so2904703wwa.1 for ; Mon, 20 Dec 2010 05:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=vuoKbIn9eXfpRubhUKeXI1JSF+03Gzw7MZexAgjIXs0=; b=vGmFMT5nYfnN+C421wT863UvKe62S/qyiY9kiQdXI8iXsgLzic3s8SLDmBruyUN3Ur hZcM7otl5y0FZTG130jewZabSW12SovZkbr/KKcR4NLzbZTM93J/M9HwDDXPyrfywqA4 lByXA86dddpJ/AWe4IbCh/6uyYzK+7Rjl3YiM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=GaFjovzK8S7OiN3q8zFhr+BYbYblfKO+fjyBVJ4UNANQjYH1zzbQLALre8f6BoEQvP QMgOc22cHPPlkR/IdfrM3JaZlfnkKfMCbIHkQUbKV6sN9TKhr3/7TYmw0ZSemlYLtMC2 VrV7EVzIhkfW92I06cS2gzTgEqOOAqTbiExcY= Received: by 10.216.154.8 with SMTP id g8mr1218241wek.12.1292850037064; Mon, 20 Dec 2010 05:00:37 -0800 (PST) Received: from bicker ([41.202.225.144]) by mx.google.com with ESMTPS id o33sm1835180wej.37.2010.12.20.05.00.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Dec 2010 05:00:36 -0800 (PST) Date: Mon, 20 Dec 2010 16:00:18 +0300 From: Dan Carpenter To: David Dillow Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] typhoon: memory corruption in typhoon_get_drvinfo() Message-ID: <20101220130018.GX1936@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org info->version only has space for 32 characters but my UTS_RELEASE is "2.6.37-rc6-next-20101217-05817-ge935fc8-dirty" so it doesn't fit. This is supposed to be the version of the driver, not the kernel version. This driver doesn't have a version so lets just leave it blank. Signed-off-by: Dan Carpenter --- Found with static analysis. Compile tested. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 5b83c3f..a3c46f6 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -1004,7 +1004,6 @@ typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) } strcpy(info->driver, KBUILD_MODNAME); - strcpy(info->version, UTS_RELEASE); strcpy(info->bus_info, pci_name(pci_dev)); }