From patchwork Mon Dec 20 09:26:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 76176 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6873DB7088 for ; Mon, 20 Dec 2010 20:26:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787Ab0LTJ0O (ORCPT ); Mon, 20 Dec 2010 04:26:14 -0500 Received: from mail-ww0-f42.google.com ([74.125.82.42]:34638 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754317Ab0LTJ0M (ORCPT ); Mon, 20 Dec 2010 04:26:12 -0500 Received: by wwi17 with SMTP id 17so2607313wwi.1 for ; Mon, 20 Dec 2010 01:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=wZ8OY9yHQhhUkM1wWVoLBqf+Y9u1i/CoQGk4+hB01zo=; b=bGa0oSM+jhhk15Nul0Si8gy6E+n98+jRoqo2cjF8IDoFEP2bwsPHUVFBUxwpRmd/Um 7DoB9h+V3ujlF62kzZ7w+lpMA4XjDBTV8t9eT4vjsBmF5snx3Ch4O/kfKFR0H8mHjiMN jbkZGL3GTYTDsNB/j1LkBTSnJ4Rg6a8Ch7XL0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=wBkmws++HFTfusMkjEfi4ma4P3SqDGjpWy97PRHPOoTe+akdtk5A1R3nUYxRVFWYt3 jefce/yQXR5nuX7jv6lJGs+s4yRKxYIQ1DQj4iGupn/XGffg6CvJszOmHM3ep5eLs2/P QZ5+VgN1V9n9l4LNUnalFSw9XzjvkhI5IJ3n4= Received: by 10.227.93.32 with SMTP id t32mr2431069wbm.158.1292837171136; Mon, 20 Dec 2010 01:26:11 -0800 (PST) Received: from bicker (h14ba.n2.ips.mtn.co.ug [212.88.116.186]) by mx.google.com with ESMTPS id q18sm2523868wbe.11.2010.12.20.01.26.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Dec 2010 01:26:10 -0800 (PST) Date: Mon, 20 Dec 2010 12:26:01 +0300 From: Dan Carpenter To: Wolfgang Grandegger Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] pch_can: off by one bugs Message-ID: <20101220092601.GS1936@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org priv->tx_enable[] has PCH_TX_OBJ_END elements so this code is reading and writing one past the end of the array. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index 8d45fdd..b2c1292 100644 --- a/drivers/net/can/pch_can.c +++ b/drivers/net/can/pch_can.c @@ -1077,7 +1077,7 @@ static int pch_can_suspend(struct pci_dev *pdev, pm_message_t state) pch_can_set_int_enables(priv, PCH_CAN_DISABLE); /* Save Tx buffer enable state */ - for (i = PCH_TX_OBJ_START; i <= PCH_TX_OBJ_END; i++) + for (i = PCH_TX_OBJ_START; i < PCH_TX_OBJ_END; i++) priv->tx_enable[i] = pch_can_get_rxtx_ir(priv, i, PCH_TX_IFREG); /* Disable all Transmit buffers */ @@ -1138,7 +1138,7 @@ static int pch_can_resume(struct pci_dev *pdev) pch_can_set_optmode(priv); /* Enabling the transmit buffer. */ - for (i = PCH_TX_OBJ_START; i <= PCH_TX_OBJ_END; i++) + for (i = PCH_TX_OBJ_START; i < PCH_TX_OBJ_END; i++) pch_can_set_rxtx(priv, i, priv->tx_enable[i], PCH_TX_IFREG); /* Configuring the receive buffer and enabling them. */