From patchwork Wed Dec 8 08:21:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Bogendoerfer X-Patchwork-Id: 74658 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5B435B70AA for ; Wed, 8 Dec 2010 20:33:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133Ab0LHJdf (ORCPT ); Wed, 8 Dec 2010 04:33:35 -0500 Received: from elvis.franken.de ([193.175.24.41]:39256 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132Ab0LHJdc (ORCPT ); Wed, 8 Dec 2010 04:33:32 -0500 X-Greylist: delayed 4273 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Dec 2010 04:33:32 EST Received: from uucp (helo=solo.franken.de) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1PQFI2-0006No-00; Wed, 08 Dec 2010 09:22:18 +0100 Received: by solo.franken.de (Postfix, from userid 1000) id 407022397DD; Wed, 8 Dec 2010 09:21:52 +0100 (CET) From: Thomas Bogendoerfer To: netdev@vger.kernel.org, j.dumon@option.com Subject: [PATCH] IP checksuming doesn't work on GE0301 option cards Message-Id: <20101208082152.407022397DD@solo.franken.de> Date: Wed, 8 Dec 2010 09:21:52 +0100 (CET) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is definitly a problem, that some option cards send up broken IP pakets leading to corrupted IP packets. These corruptions aren't detected, because the driver claims that the packets are already checksummed. This change removes the CHECKSUM_UNNECESSARY option and let IP detect broken data. Signed-off-by: Thomas Bogendoerfer --- drivers/net/usb/hso.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index b154a94..1f94f92 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -958,10 +958,6 @@ static void packetizeRx(struct hso_net *odev, unsigned char *ip_pkt, /* Packet is complete. Inject into stack. */ /* We have IP packet here */ odev->skb_rx_buf->protocol = cpu_to_be16(ETH_P_IP); - /* don't check it */ - odev->skb_rx_buf->ip_summed = - CHECKSUM_UNNECESSARY; - skb_reset_mac_header(odev->skb_rx_buf); /* Ship it off to the kernel */