From patchwork Thu Nov 18 06:42:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerrit Renker X-Patchwork-Id: 72055 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42CEAB71B0 for ; Thu, 18 Nov 2010 17:53:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224Ab0KRGxd (ORCPT ); Thu, 18 Nov 2010 01:53:33 -0500 Received: from dee.erg.abdn.ac.uk ([139.133.204.82]:39234 "EHLO erg.abdn.ac.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752216Ab0KRGxc (ORCPT ); Thu, 18 Nov 2010 01:53:32 -0500 X-Greylist: delayed 682 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Nov 2010 01:53:32 EST Received: from laptev.erg.abdn.ac.uk (Debian-exim@ra-gerrit.erg.abdn.ac.uk [139.133.204.38]) by erg.abdn.ac.uk (8.13.4/8.13.4) with ESMTP id oAI6g0Kw018505 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 18 Nov 2010 06:42:01 GMT Received: from gerrit by laptev.erg.abdn.ac.uk with local (Exim 4.69) (envelope-from ) id 1PIyC0-0001QV-GF; Thu, 18 Nov 2010 07:42:00 +0100 Date: Thu, 18 Nov 2010 07:42:00 +0100 From: Gerrit Renker To: David Miller Cc: dccp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: net-next-2.6 [PATCH 0/6]: dccp ccid-2: Ack Vector patch set second/concluding part II Message-ID: <20101118064200.GA5457@gerrit.erg.abdn.ac.uk> Mail-Followup-To: Gerrit Renker , David Miller , dccp@vger.kernel.org, netdev@vger.kernel.org References: <1289802547-5617-1-git-send-email-gerrit@erg.abdn.ac.uk> <20101115.110459.68121782.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101115.110459.68121782.davem@davemloft.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-ERG-MailScanner: Found to be clean X-ERG-MailScanner-From: gerrit@erg.abdn.ac.uk X-Spam-Status: No Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Some of the new functions you added had some coding style quirks, > for example the openning brace for dccp_ackvec_clear_state() > has an unnecessary space before it on that line. > > Please fix those sorts of things up, thanks. I am sorry, this glitch must have occurred since I last ran checkpatch.pl. Please find a fix attached. I have checked all patches again, line-by-line and using checkpatch.pl. I found only this one occurrence, checking twice. It is also on top today's copy of net-next-2.6, on git://eden-feed.erg.abdn.ac.uk/net-next-2.6 [subtree 'dccp'] (I tried to put up the patches on top of this, but this did not work cleanly, due to inter-dependencies. I apologize for this.) >>>>>>>>>>>>>>>>>>>>>>>>>> Patch <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< dccp ccid-2: whitespace fix-up This fixes whitespace noise introduced in commit "dccp ccid-2: Algorithm to update buffer state", 5753fdfe8bd8e9a2ff9e5af19b0ffc78bfcd502a, 14 Nov 2010. Signed-off-by: Gerrit Renker --- ackvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c @@ -282,7 +282,7 @@ void dccp_ackvec_input(struct dccp_ackvec *av, struct sk_buff *skb) * packet of group (2) in 11.4.2. */ void dccp_ackvec_clear_state(struct dccp_ackvec *av, const u64 ackno) - { +{ struct dccp_ackvec_record *avr, *next; u8 runlen_now, eff_runlen; s64 delta;