From patchwork Sat Sep 18 23:42:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 65141 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 76D5EB70CE for ; Sun, 19 Sep 2010 09:42:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555Ab0IRXml (ORCPT ); Sat, 18 Sep 2010 19:42:41 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:35659 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204Ab0IRXmk (ORCPT ); Sat, 18 Sep 2010 19:42:40 -0400 Received: by pvg2 with SMTP id 2so872092pvg.19 for ; Sat, 18 Sep 2010 16:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=MaKm2bb6cm9I5E836egJsLjy9ezTWjIzNpumPFAiQGI=; b=e3XG0krMSS4U6wesdMBjJozEn12tUmPhHZvu9QMwPw46Hu3kK4DSwbGB+NfiD4DpLt u8raMFzHegbeVDINqGPmQDaN1JyjcYfbIK0nn4o9CeQlVYZo5MbzB3Ek3KNTaS1zR5hE iPMf6q/RdFKqSWdFG60506E3mECbCl+aYlzCs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=Bdi2Bs+E0qH5wUB+E6jmYL5BCYx/z6Fs/9BtHLpIp4M4LzJh8yK1CgXzEV2Gobddb8 qtVOSH5sEiisDK1Z9qpN0t5bhFCDMuT5G9uEwt68Fds5mKnEbJjhLe2VlznniGldzapk 5DT9oVl2/8CYnx2oHh2a0Lp1iaccjFlAY0RTY= Received: by 10.114.15.18 with SMTP id 18mr7675358wao.182.1284853359916; Sat, 18 Sep 2010 16:42:39 -0700 (PDT) Received: from bicker ([41.205.146.22]) by mx.google.com with ESMTPS id c10sm9843580wam.1.2010.09.18.16.42.34 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 18 Sep 2010 16:42:39 -0700 (PDT) Date: Sun, 19 Sep 2010 01:42:25 +0200 From: Dan Carpenter To: Andy Grover Cc: "David S. Miller" , rds-devel@oss.oracle.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] rds: signedness bug Message-ID: <20100918234224.GC6236@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the original code if the copy_from_user() fails in rds_rdma_pages() then the error handling fails and we get a stack trace from kmalloc(). Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/rds/rdma.c b/net/rds/rdma.c index 4806467..1a41deb 100644 --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -522,7 +522,7 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm, struct rds_rdma_args *args; struct rds_iovec vec; struct rm_rdma_op *op = &rm->rdma; - unsigned int nr_pages; + int nr_pages; unsigned int nr_bytes; struct page **pages = NULL; struct rds_iovec __user *local_vec;