From patchwork Sat Sep 18 23:41:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 65140 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A03D7B70CE for ; Sun, 19 Sep 2010 09:42:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404Ab0IRXmE (ORCPT ); Sat, 18 Sep 2010 19:42:04 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:64667 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204Ab0IRXmC (ORCPT ); Sat, 18 Sep 2010 19:42:02 -0400 Received: by pzk34 with SMTP id 34so871043pzk.19 for ; Sat, 18 Sep 2010 16:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=RwCcPbm1bd+hF4khLYr3JdenbCeKgQsXSm7r+nYqx+E=; b=NYhs+nk4YHQ3ycGUHH7zt6cNuEInYgWacVGpmjJj8uJPhb2NxDQgpI9l+X8rMHKP2L v/KJM/Hc9hbDXUgOG1885gi/1BPyO2WM9+/ZK+1nEH2wLdZrxpjJmKSoqAHIPjS6DM3r e2lyGRRnK16ntaEqFzyNVU5QK8YRkw8cvNs20= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=gW8JXMpKdMYaoTJaQpU8tvOyCJK3QtF5mc4JhhgAdhlSXOFCnWIjLXFrMDEyL4KMGe nPYLJYfcTYmISGyYrVNm7aSXA3NFYu3WTelaPEhDzaUPnkM4TKteE31+ctCggGdTpdqe N2P9sZa1Ih5t5W0NPBovtDI06cO3g799aQP/s= Received: by 10.114.126.2 with SMTP id y2mr7761604wac.57.1284853321717; Sat, 18 Sep 2010 16:42:01 -0700 (PDT) Received: from bicker ([41.205.146.22]) by mx.google.com with ESMTPS id c10sm9836334wam.13.2010.09.18.16.41.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 18 Sep 2010 16:42:00 -0700 (PDT) Date: Sun, 19 Sep 2010 01:41:44 +0200 From: Dan Carpenter To: Rasesh Mody Cc: Debashis Dutt , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] bna: off by one Message-ID: <20100918234144.GB6236@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The mod->mbhdlr[] array has BFI_MC_MAX elements. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/bna/bfa_ioc.c b/drivers/net/bna/bfa_ioc.c index caa45c2..73493de 100644 --- a/drivers/net/bna/bfa_ioc.c +++ b/drivers/net/bna/bfa_ioc.c @@ -1514,7 +1514,7 @@ bfa_nw_ioc_mbox_isr(struct bfa_ioc *ioc) return; } - if ((mc > BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL)) + if ((mc >= BFI_MC_MAX) || (mod->mbhdlr[mc].cbfn == NULL)) return; mod->mbhdlr[mc].cbfn(mod->mbhdlr[mc].cbarg, &m);