From patchwork Fri Aug 6 08:23:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 61074 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5D621B6EFE for ; Fri, 6 Aug 2010 18:24:10 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932452Ab0HFIYG (ORCPT ); Fri, 6 Aug 2010 04:24:06 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:49144 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491Ab0HFIYC (ORCPT ); Fri, 6 Aug 2010 04:24:02 -0400 Received: by wyb39 with SMTP id 39so7501274wyb.19 for ; Fri, 06 Aug 2010 01:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=rQplEIwOHSsFW0su6J6jN2ShBvpI9Kq2B+Y19zQKihg=; b=DIOJ00Fp6V57E569MqxCJeRKU8YI4mNsnV2Q9LKGP99NcyCbaio8s050eTXgF2Hs1o +E0nIeABbaGqrK1UltXczlp7UDlSgo4fL67ER4YY4EBGdGcreVsWwnDFjBAs+3u2+7PQ 5OeaZ+i46gJRYFNl2L/G+lGRme9Yz8+7y//uQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=tHRuzJoOhudYg7d9syl3oWATt+xxlLw4HO6cFRuB2iIiVAaUfwaARNV/lFWIid4cME MPlwAvKhQ+a/M1Gpmj5+DP0kxDVKGv3NH5nwN4rJMKJ2MCoHiuz1ow0X/GHXoHdRyStU 4q1H/eIsgd49J2GhunM2IHz4LAosGNYAPlVz0= Received: by 10.227.127.65 with SMTP id f1mr10353893wbs.118.1281083038336; Fri, 06 Aug 2010 01:23:58 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id p42sm683404weq.12.2010.08.06.01.23.40 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Aug 2010 01:23:58 -0700 (PDT) Date: Fri, 6 Aug 2010 10:23:23 +0200 From: Dan Carpenter To: Hansjoerg Lipp Cc: Tilman Schmidt , Karsten Keil , "David S. Miller" , Andy Shevchenko , gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] isdn: gigaset: add missing unlock Message-ID: <20100806082323.GU9031@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We should unlock here. This is the only place where we return from the function with the lock held. The caller isn't expecting it. Signed-off-by: Dan Carpenter Acked-by: Tilman Schmidt --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c index e5ea344..bcc174e 100644 --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs, do { if (bcap->bcnext == ap) { bcap->bcnext = bcap->bcnext->bcnext; + spin_unlock_irqrestore(&bcs->aplock, flags); return; } bcap = bcap->bcnext;