From patchwork Wed Jun 30 09:02:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 57385 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 993EBB6EF7 for ; Wed, 30 Jun 2010 19:02:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210Ab0F3JCb (ORCPT ); Wed, 30 Jun 2010 05:02:31 -0400 Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:50309 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079Ab0F3JCa (ORCPT ); Wed, 30 Jun 2010 05:02:30 -0400 Received: id: bigeasy by Chamillionaire.breakpoint.cc with local (easymta 1.00 BETA 1) id 1OTtBd-0006gY-6d; Wed, 30 Jun 2010 11:02:29 +0200 Date: Wed, 30 Jun 2010 11:02:29 +0200 From: Sebastian Andrzej Siewior To: David Miller Cc: netdev@vger.kernel.org Subject: [PATCH v2] net/core: use ntohs for skb->protocol Message-ID: <20100630090229.GB25541@Chamillionaire.breakpoint.cc> References: <20100629163246.GA18647@Chamillionaire.breakpoint.cc> <20100629.151740.135534374.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100629.151740.135534374.davem@davemloft.net> X-Key-Id: FE3F4706 X-Key-Fingerprint: FFDA BBBB 3563 1B27 75C9 925B 98D5 5C1C FE3F 4706 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sebastian Andrzej Siewior This is only noticed by people that are not doing everything correct in the first place. Signed-off-by: Sebastian Andrzej Siewior --- net/core/dev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index eb4be99..8e61dc5 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1537,7 +1537,8 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) if (net_ratelimit()) printk(KERN_CRIT "protocol %04x is " "buggy, dev %s\n", - skb2->protocol, dev->name); + ntohs(skb2->protocol), + dev->name); skb_reset_network_header(skb2); }