From patchwork Mon Jun 28 21:20:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 57192 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05351B6EE8 for ; Tue, 29 Jun 2010 07:22:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206Ab0F1VWh (ORCPT ); Mon, 28 Jun 2010 17:22:37 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:37116 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380Ab0F1VWg (ORCPT ); Mon, 28 Jun 2010 17:22:36 -0400 Received: by mail-iw0-f174.google.com with SMTP id 7so406712iwn.19 for ; Mon, 28 Jun 2010 14:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=6sLaQ9pFpTFMYSXDhKctYfStYJXuKa8RQJjKlpo37ZU=; b=hnwrVUSmXpJSHYO894+85U4z9X2aYQmOXpRmPYNRfg/iSz1pCGlehNMoQPKye1ZxWN oM8H8vD28/fhiUWE+V6hQ2swpQ2oC8dsqWvEfl+kg0XknQJDA/krirYivbG0SwNfeWWN IfJFxgSCHKBbyB7qgTw/4d8faGhM6HWrvSu8Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=jYu5lYexf11JRKRqOeUZsyRU+a3LZAocWT1A+P4UlSX8cwT/0KWzqfeujBi4gvoX38 cAEMO5NtkM7jFBdvydDH/08zMZ9SDfel4QH95+u+sM125vaWRwfSh93P/9euk16Y98V9 pL+kO5PY6GVSpEi5wI1aKf2aAx1G0O9cjaK3s= Received: by 10.231.13.203 with SMTP id d11mr5180430iba.131.1277760154036; Mon, 28 Jun 2010 14:22:34 -0700 (PDT) Received: from bicker ([205.177.176.130]) by mx.google.com with ESMTPS id h8sm7759328ibk.15.2010.06.28.14.22.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 28 Jun 2010 14:22:33 -0700 (PDT) Date: Mon, 28 Jun 2010 23:20:46 +0200 From: Dan Carpenter To: Hansjoerg Lipp Cc: Tilman Schmidt , Karsten Keil , "David S. Miller" , gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] isdn/gigaset: add a kfree() to error path Message-ID: <20100628212046.GM19184@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We should free "commands" here. The main reason is to please the static checkers. Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c index f01c3c2..f1abb8f 100644 --- a/drivers/isdn/gigaset/i4l.c +++ b/drivers/isdn/gigaset/i4l.c @@ -419,6 +419,7 @@ oom: dev_err(bcs->cs->dev, "out of memory\n"); for (i = 0; i < AT_NUM; ++i) kfree(commands[i]); + kfree(commands); return -ENOMEM; }