From patchwork Sat May 29 04:01:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junchang Wang X-Patchwork-Id: 53972 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4EADFB7D16 for ; Sat, 29 May 2010 15:04:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236Ab0E2FET (ORCPT ); Sat, 29 May 2010 01:04:19 -0400 Received: from [58.211.218.74] ([58.211.218.74]:59200 "EHLO host-a-55.ustcsz.edu.cn" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750953Ab0E2FES (ORCPT ); Sat, 29 May 2010 01:04:18 -0400 X-Greylist: delayed 3789 seconds by postgrey-1.27 at vger.kernel.org; Sat, 29 May 2010 01:04:17 EDT Received: from host-a-55.ustcsz.edu.cn (localhost.localdomain [127.0.0.1]) by host-a-55.ustcsz.edu.cn (8.13.8/8.13.8) with ESMTP id o4T41EeR029052; Sat, 29 May 2010 12:01:14 +0800 Received: (from wangjc@localhost) by host-a-55.ustcsz.edu.cn (8.13.8/8.13.8/Submit) id o4T41BQQ029025; Sat, 29 May 2010 12:01:11 +0800 Date: Sat, 29 May 2010 12:01:11 +0800 From: Junchang Wang To: romieu@fr.zoreil.com Cc: netdev@vger.kernel.org Subject: [Patch] r8169: use u32 instead of unsigned long Message-ID: <20100529040111.GA28225@host-a-55.ustcsz.edu.cn> Mime-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RTL_R32 should return value with 32-bit width. But "unsigned long" implies u64 on some 64-bit platforms. Signed-off-by: Junchang Wang --- Sorry for coding style flaw in previous email. drivers/net/r8169.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 217e709..4234d6a 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32; #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg)) #define RTL_R8(reg) readb (ioaddr + (reg)) #define RTL_R16(reg) readw (ioaddr + (reg)) -#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg))) +#define RTL_R32(reg) ((u32) readl(ioaddr + (reg))) enum mac_version { RTL_GIGA_MAC_NONE = 0x00,