From patchwork Wed May 5 08:30:47 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 51676 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6CB08B7D4F for ; Wed, 5 May 2010 18:33:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932931Ab0EEIay (ORCPT ); Wed, 5 May 2010 04:30:54 -0400 Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:48730 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104Ab0EEIax (ORCPT ); Wed, 5 May 2010 04:30:53 -0400 Received: id: bigeasy by Chamillionaire.breakpoint.cc with local (easymta 1.00 BETA 1) id 1O9a0F-0001E2-4x; Wed, 05 May 2010 10:30:47 +0200 Date: Wed, 5 May 2010 10:30:47 +0200 From: Sebastian Andrzej Siewior To: David Miller Cc: afleming@gmail.com, afleming@freescale.com, netdev@vger.kernel.org Subject: [PATCH v2] net/gianfar: drop recycled skbs on MTU change Message-ID: <20100505083047.GA4398@Chamillionaire.breakpoint.cc> References: <20100503151745.GA17997@Chamillionaire.breakpoint.cc> <20100505.005704.115933493.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100505.005704.115933493.davem@davemloft.net> X-Key-Id: FE3F4706 X-Key-Fingerprint: FFDA BBBB 3563 1B27 75C9 925B 98D5 5C1C FE3F 4706 User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sebastian Andrzej Siewior The size for skbs which is added to the recycled list is using the current descriptor size which is current MTU. gfar_new_skb() is also using this size. So after changing or alteast increasing the MTU all recycled skbs should be dropped. Signed-off-by: Sebastian Andrzej Siewior Acked-by: Andy Fleming --- >> I think we should probably do this in free_skb_resources. And remove >> the call from gfar_close(). > >Ok, Sebastian please rework your patch as requested by Andy. This has the side effect of dropping them on reset which is not required. drivers/net/gianfar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 4e97ca1..5d3763f 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1649,6 +1649,7 @@ static void free_skb_resources(struct gfar_private *priv) sizeof(struct rxbd8) * priv->total_rx_ring_size, priv->tx_queue[0]->tx_bd_base, priv->tx_queue[0]->tx_bd_dma_base); + skb_queue_purge(&priv->rx_recycle); } void gfar_start(struct net_device *dev) @@ -2088,7 +2089,6 @@ static int gfar_close(struct net_device *dev) disable_napi(priv); - skb_queue_purge(&priv->rx_recycle); cancel_work_sync(&priv->reset_task); stop_gfar(dev);