From patchwork Mon Apr 12 08:35:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sathya Perla X-Patchwork-Id: 49950 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B5B02B7D18 for ; Mon, 12 Apr 2010 18:36:16 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340Ab0DLIgK (ORCPT ); Mon, 12 Apr 2010 04:36:10 -0400 Received: from segment-124-30.sify.net ([124.30.166.146]:61222 "EHLO sperla-laptop.localdomain" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753105Ab0DLIgJ (ORCPT ); Mon, 12 Apr 2010 04:36:09 -0400 Received: by sperla-laptop.localdomain (Postfix, from userid 1000) id B2D7617E092; Mon, 12 Apr 2010 14:05:27 +0530 (IST) Date: Mon, 12 Apr 2010 14:05:27 +0530 From: Sathya Perla To: netdev Cc: pugs@cisco.com Subject: [PATCH net-next-2.6] be2net: clarify promiscuous cmd with a comment Message-ID: <20100412083527.GA27023@serverengines.com> Reply-To: Sathya Perla MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The promiscous cmd config code gives an impression that setting a port to promisc mode will unset the other port. This is not the case and is clarified with a comment. Signed-off-by: Sathya Perla --- drivers/net/benet/be_cmds.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index da87930..e79bf8b 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1113,6 +1113,10 @@ int be_cmd_promiscuous_config(struct be_adapter *adapter, u8 port_num, bool en) be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ETH, OPCODE_ETH_PROMISCUOUS, sizeof(*req)); + /* In FW versions X.102.149/X.101.487 and later, + * the port setting associated only with the + * issuing pci function will take effect + */ if (port_num) req->port1_promiscuous = en; else