Message ID | 20100326102957.GG5539@matterhorn.verdurent.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, Mar 26, 2010 at 12:29:57PM +0200, Amit Kucheria wrote: > On 10 Mar 26, Bryan Wu wrote: > > BugLink: http://bugs.launchpad.net/bugs/457878 > > > > - removed old MII phy control code > > - add phylib supporting > > - add ethtool interface to make user space NetworkManager works > > > > Tested on Freescale i.MX51 Babbage board. > > > > This patch is based on a patch from Frederic Rodo <fred.rodo@gmail.com> > > > > Cc: Frederic Rodo <fred.rodo@gmail.com> > > Signed-off-by: Bryan Wu <bryan.wu@canonical.com> > > While I ack this patch, I wonder if we should add to the various board > Kconfig options, a dependency select'ing the right phylib for that board. > > This would prevent breakage of ethernet on those boards because they forgot > to select the right phylib after this change. I wouldn't go that far. I never saw a board which doesn't work with the generic phy implementation, so I would only select the specific phy if I knew that the generic phy does not work. Sascha
diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig index 1576d51..b67ba00 100644 --- a/arch/arm/mach-mx5/Kconfig +++ b/arch/arm/mach-mx5/Kconfig @@ -10,6 +10,7 @@ comment "MX5 platforms:" config MACH_MX51_BABBAGE bool "Support MX51 BABBAGE platforms" + select SMSC_PHY help Include support for MX51 Babbage platform, also known as MX51EVK in u-boot. This includes specific configurations for the board and its