diff mbox

Remove unused function - skb_frag_add_head

Message ID 20100115053205.31534.85551.sendpatchset@krkumar2.in.ibm.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Krishna Kumar Jan. 15, 2010, 5:32 a.m. UTC 
From: Krishna Kumar <krkumar2@in.ibm.com>

Remove unused function - skb_frag_add_head

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
 include/linux/skbuff.h |    6 ------
 1 file changed, 6 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Jan. 15, 2010, 8:40 a.m. UTC | #1 
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Fri, 15 Jan 2010 11:02:05 +0530

> From: Krishna Kumar <krkumar2@in.ibm.com>
> 
> Remove unused function - skb_frag_add_head
> 
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>

It rounds out the abstractions for accessing the fragment list.

All uses of the frag list need to be converted to these things
so that we can finally change sk_buff to use struct list_head
instead of a by-hand linked list.

So I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -ruNp org/include/linux/skbuff.h new/include/linux/skbuff.h
--- org/include/linux/skbuff.h	2009-12-29 18:29:33.000000000 +0530
+++ new/include/linux/skbuff.h	2009-12-29 18:30:06.000000000 +0530
@@ -1728,12 +1728,6 @@  static inline void skb_frag_list_init(st
 	skb_shinfo(skb)->frag_list = NULL;
 }
 
-static inline void skb_frag_add_head(struct sk_buff *skb, struct sk_buff *frag)
-{
-	frag->next = skb_shinfo(skb)->frag_list;
-	skb_shinfo(skb)->frag_list = frag;
-}
-
 #define skb_walk_frags(skb, iter)	\
 	for (iter = skb_shinfo(skb)->frag_list; iter; iter = iter->next)