From patchwork Mon Nov 9 19:02:19 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lennart Sorensen X-Patchwork-Id: 38019 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9416EB7B77 for ; Tue, 10 Nov 2009 11:00:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbZKITCP (ORCPT ); Mon, 9 Nov 2009 14:02:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753681AbZKITCO (ORCPT ); Mon, 9 Nov 2009 14:02:14 -0500 Received: from caffeine.csclub.uwaterloo.ca ([129.97.134.17]:37582 "EHLO caffeine.csclub.uwaterloo.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627AbZKITCO (ORCPT ); Mon, 9 Nov 2009 14:02:14 -0500 Received: from caffeine.csclub.uwaterloo.ca (localhost [127.0.0.1]) by caffeine.csclub.uwaterloo.ca (Postfix) with ESMTP id 99B2C1B0BF; Mon, 9 Nov 2009 19:02:19 +0000 (UTC) Received: by caffeine.csclub.uwaterloo.ca (Postfix, from userid 20367) id 8B7FA1B817; Mon, 9 Nov 2009 19:02:19 +0000 (UTC) Date: Mon, 9 Nov 2009 19:02:19 +0000 To: linux-kernel@vger.kernel.org Cc: Len Sorensen , netdev@vger.kernel.org, Paulius Zaleckas , Laurent Pinchart Subject: Fix gpio-mdio driver to work for gpio's that return something other than 0 and 1. Message-ID: <20091109190219.GB15159@caffeine.csclub.uwaterloo.ca> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The gpio-mdio driver seems to assume GPIOs return 0 and 1, although that doesn't seem to be the case. I see return values of 0 and 0x1000000 for the GPIO I happen to be using. A simple application of !! solves that though. Tested on a RuggedCom RX5000 (mpc8360e based). Signed-off-by: Lennart Sorensen --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index 8659d34..7e76f0c 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -55,7 +55,7 @@ static int mdio_get(struct mdiobb_ctrl *ctrl) struct mdio_gpio_info *bitbang = container_of(ctrl, struct mdio_gpio_info, ctrl); - return gpio_get_value(bitbang->mdio); + return !!gpio_get_value(bitbang->mdio); } static void mdio_set(struct mdiobb_ctrl *ctrl, int what)