From patchwork Tue Oct 20 09:49:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 36457 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B02D4B7B90 for ; Tue, 20 Oct 2009 20:50:03 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbZJTJtx (ORCPT ); Tue, 20 Oct 2009 05:49:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751771AbZJTJtw (ORCPT ); Tue, 20 Oct 2009 05:49:52 -0400 Received: from aeryn.fluff.org.uk ([87.194.8.8]:50627 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751701AbZJTJtw (ORCPT ); Tue, 20 Oct 2009 05:49:52 -0400 Received: from ben by kira.home.fluff.org with local (Exim 4.69) (envelope-from ) id 1N0BLm-0008Se-Cu; Tue, 20 Oct 2009 10:49:54 +0100 Message-Id: <20091020094954.310595275@fluff.org.uk> User-Agent: quilt/0.48-1 Date: Tue, 20 Oct 2009 10:49:03 +0100 From: Ben Dooks To: netdev@vger.kernel.org Cc: Ping.Doong@Micrel.Com Subject: [patch 1/3] KS8851: Add soft reset at probe time References: <20091020094902.274646871@fluff.org.uk> Content-Disposition: inline; filename=ks8851-reset-at-probe.patch Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Issue a full soft reset at probe time. This was reported by Doong Ping of Micrel, but no explanation of why this is necessary or what bug it is fixing. Add it as it does not seem to hurt the current driver and ensures that the device is in a known state when we start setting it up. Signed-off-by: Ben Dooks --- drivers/net/ks8851.c | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/net/ks8851.c =================================================================== --- a/drivers/net/ks8851.c 2009-10-12 23:04:15.000000000 +0100 +++ b/drivers/net/ks8851.c 2009-10-13 13:28:43.000000000 +0100 @@ -1239,6 +1239,9 @@ static int __devinit ks8851_probe(struct ndev->netdev_ops = &ks8851_netdev_ops; ndev->irq = spi->irq; + /* issue a global soft reset to reset the device. */ + ks8851_soft_reset(ks, GRR_GSR); + /* simple check for a valid chip being connected to the bus */ if ((ks8851_rdreg16(ks, KS_CIDER) & ~CIDER_REV_MASK) != CIDER_ID) {