From patchwork Thu Oct 1 16:16:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Ratiu X-Patchwork-Id: 34745 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B8DE3B7BCE for ; Fri, 2 Oct 2009 02:16:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358AbZJAQQj (ORCPT ); Thu, 1 Oct 2009 12:16:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752708AbZJAQQj (ORCPT ); Thu, 1 Oct 2009 12:16:39 -0400 Received: from ixro-out-rtc.ixiacom.com ([92.87.192.98]:16496 "EHLO ixro-ex1.ixiacom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751910AbZJAQQi (ORCPT ); Thu, 1 Oct 2009 12:16:38 -0400 Received: from ixro-cratiu.localnet ([10.205.9.78]) by ixro-ex1.ixiacom.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 1 Oct 2009 19:16:41 +0300 From: Cosmin Ratiu Organization: IXIA To: netdev@vger.kernel.org Subject: [PATCH] make TLLAO option for NA packets configurable Date: Thu, 1 Oct 2009 19:16:40 +0300 User-Agent: KMail/1.11.4 (Linux/2.6.30-1-686; KDE/4.2.4; i686; ; ) Cc: Octavian Purdila MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200910011916.40908.cratiu@ixiacom.com> X-OriginalArrivalTime: 01 Oct 2009 16:16:41.0442 (UTC) FILETIME=[8F9B6C20:01CA42B2] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, This is a patch that adds a sysctl to control the sending of the Target Link Layer Address Option (TLLAO) with Neighbor Advertisements responding to unicast NS. The patch was made for kernel 2.6.7 (yes it is ancient), but the code is similar with the current kernel and I can rework it if you want it in. RFC 2461, page 24 suggests that this option should be included with NAs to avoid a race with the sender clearing its cache after sending an unicast NS, but before receiving a NA. It seems there are some Juniper routers (MX series) that expect this option to be included with all NAs. Another solution is to always send this option, as it has little overhead. Please let me know what you think, Cosmin. Signed-off-by: Cosmin Ratiu --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- //packages/linux_2.6.7/main/src/include/linux/sysctl.h +++ /home/z/w1/packages/linux_2.6.7/main/src/include/linux/sysctl.h @@ -444,6 +444,7 @@ NET_IPV6_IP6FRAG_TIME=23, NET_IPV6_IP6FRAG_SECRET_INTERVAL=24, NET_IPV6_MLD_MAX_MSF=25, + NET_IPV6_NDISC_FORCE_TLLAO=26, }; enum { --- //packages/linux_2.6.7/main/src/include/net/ipv6.h +++ /home/z/w1/packages/linux_2.6.7/main/src/include/net/ipv6.h @@ -479,6 +479,7 @@ extern int sysctl_ip6frag_low_thresh; extern int sysctl_ip6frag_time; extern int sysctl_ip6frag_secret_interval; +extern int sysctl_ndisc_force_tllao; #endif /* __KERNEL__ */ #endif /* _NET_IPV6_H */ --- //packages/linux_2.6.7/main/src/net/ipv6/ndisc.c +++ /home/z/w1/packages/linux_2.6.7/main/src/net/ipv6/ndisc.c @@ -169,6 +169,8 @@ #define NDISC_OPT_SPACE(len) (((len)+2+7)&~7) +int sysctl_ndisc_force_tllao; + static u8 *ndisc_fill_option(u8 *opt, int type, void *data, int data_len) { int space = NDISC_OPT_SPACE(data_len); @@ -399,6 +401,9 @@ return; } + if (sysctl_ndisc_force_tllao) + inc_opt = 1; + if (inc_opt) { if (dev->addr_len) len += NDISC_OPT_SPACE(dev->addr_len); --- //packages/linux_2.6.7/main/src/net/ipv6/sysctl_net_ipv6.c +++ /home/z/w1/packages/linux_2.6.7/main/src/net/ipv6/sysctl_net_ipv6.c @@ -84,6 +84,14 @@ .mode = 0644, .proc_handler = &proc_dointvec }, + { + .ctl_name = NET_IPV6_NDISC_FORCE_TLLAO, + .procname = "ndisc_force_tllao", + .data = &sysctl_ndisc_force_tllao, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = &proc_dointvec, + }, { .ctl_name = 0 } };