From patchwork Sun Sep 13 06:48:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Smith X-Patchwork-Id: 33544 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 0D308B7B5F for ; Sun, 13 Sep 2009 16:48:56 +1000 (EST) Received: by ozlabs.org (Postfix) id E84E1DDD0B; Sun, 13 Sep 2009 16:48:55 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 93363DDD01 for ; Sun, 13 Sep 2009 16:48:55 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbZIMGsr (ORCPT ); Sun, 13 Sep 2009 02:48:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752613AbZIMGsq (ORCPT ); Sun, 13 Sep 2009 02:48:46 -0400 Received: from smtp1.adam.net.au ([202.136.110.253]:34175 "EHLO smtp1.adam.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbZIMGsq (ORCPT ); Sun, 13 Sep 2009 02:48:46 -0400 Received: from 114-30-119-179.ip.adam.com.au ([114.30.119.179] helo=opy.nosense.org) by smtp1.adam.net.au with esmtp (Exim 4.63) (envelope-from ) id 1MmitA-00088O-C8; Sun, 13 Sep 2009 16:18:44 +0930 Received: from opy.nosense.org (localhost.localdomain [127.0.0.1]) by opy.nosense.org (Postfix) with ESMTP id A45B849298; Sun, 13 Sep 2009 16:18:43 +0930 (CST) Date: Sun, 13 Sep 2009 16:18:43 +0930 From: Mark Smith To: netdev@vger.kernel.org, acme@redhat.com, davem@davemloft.net Subject: [PATCH net-next-2.6] Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS Message-ID: <20090913161843.2e2174ba@opy.nosense.org> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.5; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS atalk_route_packet() returns NET_RX_DROP if it's call to aarp_send_ddp() returns NET_XMIT_DROP. If aarp_send_ddp() returns anything else atalk_route_packet() should return NET_RX_SUCCESS, not NET_XMIT_SUCCESS. Signed-off-by: Mark Smith --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 4a6ff2b..b1a4290 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1372,7 +1372,7 @@ static int atalk_route_packet(struct sk_buff *skb, struct net_device *dev, if (aarp_send_ddp(rt->dev, skb, &ta, NULL) == NET_XMIT_DROP) return NET_RX_DROP; - return NET_XMIT_SUCCESS; + return NET_RX_SUCCESS; free_it: kfree_skb(skb); drop: