| Message ID | 20090913161843.2e2174ba@opy.nosense.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Mark Smith <lk-netdev@lk-netdev.nosense.org> Date: Sun, 13 Sep 2009 16:18:43 +0930 > Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS > > atalk_route_packet() returns NET_RX_DROP if it's call to > aarp_send_ddp() returns NET_XMIT_DROP. If aarp_send_ddp() returns > anything else atalk_route_packet() should return NET_RX_SUCCESS, not > NET_XMIT_SUCCESS. > > Signed-off-by: Mark Smith <markzzzsmith@yahoo.com.au> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 4a6ff2b..b1a4290 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1372,7 +1372,7 @@ static int atalk_route_packet(struct sk_buff *skb, struct net_device *dev, if (aarp_send_ddp(rt->dev, skb, &ta, NULL) == NET_XMIT_DROP) return NET_RX_DROP; - return NET_XMIT_SUCCESS; + return NET_RX_SUCCESS; free_it: kfree_skb(skb); drop:
Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS atalk_route_packet() returns NET_RX_DROP if it's call to aarp_send_ddp() returns NET_XMIT_DROP. If aarp_send_ddp() returns anything else atalk_route_packet() should return NET_RX_SUCCESS, not NET_XMIT_SUCCESS. Signed-off-by: Mark Smith <markzzzsmith@yahoo.com.au> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html