From patchwork Fri Aug 21 10:46:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andreas Mohr X-Patchwork-Id: 31814 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id BBB27B7BD2 for ; Fri, 21 Aug 2009 20:46:24 +1000 (EST) Received: by ozlabs.org (Postfix) id AEB3CDDD0B; Fri, 21 Aug 2009 20:46:24 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 3BE68DDD01 for ; Fri, 21 Aug 2009 20:46:24 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbZHUKqG (ORCPT ); Fri, 21 Aug 2009 06:46:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751642AbZHUKqF (ORCPT ); Fri, 21 Aug 2009 06:46:05 -0400 Received: from rhlx01.hs-esslingen.de ([129.143.116.10]:55217 "EHLO rhlx01.hs-esslingen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbZHUKqE (ORCPT ); Fri, 21 Aug 2009 06:46:04 -0400 Received: by rhlx01.hs-esslingen.de (Postfix, from userid 102) id 247DC400C5; Fri, 21 Aug 2009 12:46:06 +0200 (CEST) Date: Fri, 21 Aug 2009 12:46:06 +0200 From: Andreas Mohr To: Richard =?iso-8859-1?Q?R=F6jfors?= Cc: Andreas Mohr , David Miller , netdev@vger.kernel.org Subject: Re: [PATCH] Fix Micrel KSZ8842 Kconfig description Message-ID: <20090821104606.GA13440@rhlx01.hs-esslingen.de> References: <20090821102033.GA26577@rhlx01.hs-esslingen.de> <4A8E78C1.20409@mocean-labs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A8E78C1.20409@mocean-labs.com> X-Priority: none User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Fri, Aug 21, 2009 at 12:36:49PM +0200, Richard Röjfors wrote: > Andreas Mohr wrote: >> Hi, >> >> when doing a "make oldconfig" recently, non-descriptive item "Micrel KSZ8842" >> came up, and when I hit "?" to get more info, all I got was a tight-lipped >> "This platform driver is for Micrel KSZ8842 chip.". > > I see your pain Thanks, and very fast reply too :) > Remove "PCI-based" > > This is a platform device, it is not PCI based. > The KS8842 can sit behind PCI, ISA or VLB, this driver basically > supports the ISA mappings. > > --Richard OK, I had added that because manufacturer specifications seemed to suggest PCI use only. "platform device" should have been a warning sign I guess... Signed-off-by: Andreas Mohr Acked-by: Richard Röjfors --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.31-rc6/drivers/net/Kconfig.orig 2009-08-21 12:00:31.000000000 +0200 +++ linux-2.6.31-rc6/drivers/net/Kconfig 2009-08-21 12:41:48.000000000 +0200 @@ -1727,7 +1727,8 @@ config KS8842 tristate "Micrel KSZ8842" depends on HAS_IOMEM help - This platform driver is for Micrel KSZ8842 chip. + This platform driver is for Micrel KSZ8842 / KS8842 + 2-port ethernet switch chip (managed, VLAN, QoS). config KS8851 tristate "Micrel KS8851 SPI"