From patchwork Mon Aug 10 13:43:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sathya Perla X-Patchwork-Id: 31077 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id DA918B6EDE for ; Mon, 10 Aug 2009 23:43:59 +1000 (EST) Received: by ozlabs.org (Postfix) id D1981DDD0C; Mon, 10 Aug 2009 23:43:59 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 691E4DDD0B for ; Mon, 10 Aug 2009 23:43:59 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbZHJNnw (ORCPT ); Mon, 10 Aug 2009 09:43:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754578AbZHJNnw (ORCPT ); Mon, 10 Aug 2009 09:43:52 -0400 Received: from segment-124-30.sify.net ([124.30.166.146]:43298 "EHLO sperla-laptop.localdomain" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754567AbZHJNnv (ORCPT ); Mon, 10 Aug 2009 09:43:51 -0400 Received: by sperla-laptop.localdomain (Postfix, from userid 1000) id 479D617E6B1; Mon, 10 Aug 2009 19:13:23 +0530 (IST) Date: Mon, 10 Aug 2009 19:13:23 +0530 From: Sathya Perla To: netdev Subject: [net-next-2.6 PATCH 2/3] be2net: fix bad queue traversal in be_rx_q_clean() Message-ID: <20090810134323.GA10857@serverengines.com> Reply-To: Sathya Perla MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Using "for(tail != head)" to traverse a queue from tail to head fails in the case of a fully filled queue. Use "for(used != 0)" instead. Signed-off-by: Sathya Perla --- drivers/net/benet/be_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index f7f8660..49c17ed 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -1010,7 +1010,7 @@ static void be_rx_q_clean(struct be_adapter *adapter) /* Then free posted rx buffer that were not used */ tail = (rxq->head + rxq->len - atomic_read(&rxq->used)) % rxq->len; - for (; tail != rxq->head; index_inc(&tail, rxq->len)) { + for (; atomic_read(&rxq->used) > 0; index_inc(&tail, rxq->len)) { page_info = get_rx_page_info(adapter, tail); put_page(page_info->page); memset(page_info, 0, sizeof(*page_info));