| Message ID | 20090704062321.034802084@openvz.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, 04 Jul 2009 10:11:58 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote: > In case if kernel was compiled without ebtables support > there is no need to keep ebt_table pointers in netns_xt > structure. > > Make it config dependent. > > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> > --- > > Probably GCC will authomatically shrink the structure > if the members are not in use. Please review. > > include/net/netns/x_tables.h | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.git/include/net/netns/x_tables.h > ===================================================================== > --- linux-2.6.git.orig/include/net/netns/x_tables.h > +++ linux-2.6.git/include/net/netns/x_tables.h > @@ -8,8 +8,11 @@ struct ebt_table; > > struct netns_xt { > struct list_head tables[NFPROTO_NUMPROTO]; > +#if defined(CONFIG_BRIDGE_NF_EBTABLES) || \ > + defined(CONFIG_BRIDGE_NF_EBTABLES_MODULE) > struct ebt_table *broute_table; > struct ebt_table *frame_filter; > struct ebt_table *frame_nat; > +#endif > }; > #endif > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Index: linux-2.6.git/include/net/netns/x_tables.h ===================================================================== --- linux-2.6.git.orig/include/net/netns/x_tables.h +++ linux-2.6.git/include/net/netns/x_tables.h @@ -8,8 +8,11 @@ struct ebt_table; struct netns_xt { struct list_head tables[NFPROTO_NUMPROTO]; +#if defined(CONFIG_BRIDGE_NF_EBTABLES) || \ + defined(CONFIG_BRIDGE_NF_EBTABLES_MODULE) struct ebt_table *broute_table; struct ebt_table *frame_filter; struct ebt_table *frame_nat; +#endif }; #endif
In case if kernel was compiled without ebtables support there is no need to keep ebt_table pointers in netns_xt structure. Make it config dependent. Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> --- Probably GCC will authomatically shrink the structure if the members are not in use. Please review. include/net/netns/x_tables.h | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html