From patchwork Fri Jun 26 20:46:08 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 29209 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 39343B7092 for ; Sat, 27 Jun 2009 06:46:16 +1000 (EST) Received: by ozlabs.org (Postfix) id 29B81DDD0C; Sat, 27 Jun 2009 06:46:16 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B3E2FDDDA1 for ; Sat, 27 Jun 2009 06:46:15 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755645AbZFZUqJ (ORCPT ); Fri, 26 Jun 2009 16:46:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754997AbZFZUqG (ORCPT ); Fri, 26 Jun 2009 16:46:06 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:34406 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755405AbZFZUqG (ORCPT ); Fri, 26 Jun 2009 16:46:06 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 96DCA163839; Fri, 26 Jun 2009 22:46:08 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id 7C96D45C068; Fri, 26 Jun 2009 22:46:08 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 5/5] decnet: Use rcu_barrier() on module unload. To: "David S. Miller" Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer Date: Fri, 26 Jun 2009 22:46:08 +0200 Message-ID: <20090626204608.10664.84674.stgit@localhost> In-Reply-To: <20090626204152.10664.69628.stgit@localhost> References: <20090626204152.10664.69628.stgit@localhost> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The decnet module unloading as been disabled with a '#if 0' statement, because it have had issues. We add a rcu_barrier() anyhow for correctness. The maintainer (Chrissie Caulfield) will look into the unload issue when time permits. Acked-by: Paul E. McKenney Acked-by: Chrissie Caulfield Signed-off-by: Jesper Dangaard Brouer --- net/decnet/af_decnet.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index d351b8d..77d4028 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c @@ -2413,6 +2413,8 @@ static void __exit decnet_exit(void) proc_net_remove(&init_net, "decnet"); proto_unregister(&dn_proto); + + rcu_barrier_bh(); /* Wait for completion of call_rcu_bh()'s */ } module_exit(decnet_exit); #endif