From patchwork Fri Jun 26 20:45:58 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 29207 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 90746B708F for ; Sat, 27 Jun 2009 06:46:05 +1000 (EST) Received: by ozlabs.org (Postfix) id 83AF8DDDB2; Sat, 27 Jun 2009 06:46:05 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 17FD0DDDA0 for ; Sat, 27 Jun 2009 06:46:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbZFZUp5 (ORCPT ); Fri, 26 Jun 2009 16:45:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754584AbZFZUp4 (ORCPT ); Fri, 26 Jun 2009 16:45:56 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:34395 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754444AbZFZUp4 (ORCPT ); Fri, 26 Jun 2009 16:45:56 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 94633163839; Fri, 26 Jun 2009 22:45:58 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id 5F1BF45C068; Fri, 26 Jun 2009 22:45:58 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 3/5] sunrpc: Use rcu_barrier() on unload. To: "David S. Miller" Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer Date: Fri, 26 Jun 2009 22:45:58 +0200 Message-ID: <20090626204558.10664.22621.stgit@localhost> In-Reply-To: <20090626204152.10664.69628.stgit@localhost> References: <20090626204152.10664.69628.stgit@localhost> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The sunrpc module uses rcu_call() thus it should use rcu_barrier() on module unload. Have not verified that the possibility for new call_rcu() callbacks has been disabled. As a hint for checking, the functions calling call_rcu() (unx_destroy_cred and generic_destroy_cred) are registered as crdestroy function pointer in struct rpc_credops. Acked-by: Paul E. McKenney Acked-by: Trond Myklebust Signed-off-by: Jesper Dangaard Brouer --- net/sunrpc/sunrpc_syms.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c index 843629f..adaa819 100644 --- a/net/sunrpc/sunrpc_syms.c +++ b/net/sunrpc/sunrpc_syms.c @@ -66,6 +66,7 @@ cleanup_sunrpc(void) #ifdef CONFIG_PROC_FS rpc_proc_exit(); #endif + rcu_barrier(); /* Wait for completion of call_rcu()'s */ } MODULE_LICENSE("GPL"); module_init(init_sunrpc);