From patchwork Fri Jun 26 20:45:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 29206 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E433AB708F for ; Sat, 27 Jun 2009 06:46:04 +1000 (EST) Received: by ozlabs.org (Postfix) id D8924DDDB2; Sat, 27 Jun 2009 06:46:04 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 6FF99DDDA0 for ; Sat, 27 Jun 2009 06:46:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071AbZFZUpv (ORCPT ); Fri, 26 Jun 2009 16:45:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754049AbZFZUpv (ORCPT ); Fri, 26 Jun 2009 16:45:51 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:34391 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbZFZUpu (ORCPT ); Fri, 26 Jun 2009 16:45:50 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 6CB0F163839; Fri, 26 Jun 2009 22:45:53 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id 512B645C068; Fri, 26 Jun 2009 22:45:53 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 2/5] mac80211: Use rcu_barrier() on unload. To: "David S. Miller" Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer Date: Fri, 26 Jun 2009 22:45:53 +0200 Message-ID: <20090626204553.10664.57323.stgit@localhost> In-Reply-To: <20090626204152.10664.69628.stgit@localhost> References: <20090626204152.10664.69628.stgit@localhost> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The mac80211 module uses rcu_call() thus it should use rcu_barrier() on module unload. The rcu_barrier() is placed in mech.c ieee80211_stop_mesh() which is invoked from ieee80211_stop() in case vif.type == NL80211_IFTYPE_MESH_POINT. Acked-by: Paul E. McKenney Acked-by: Johannes Berg Signed-off-by: Jesper Dangaard Brouer --- net/mac80211/mesh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index fc712e6..11cf45b 100644 --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -494,7 +494,7 @@ void ieee80211_stop_mesh(struct ieee80211_sub_if_data *sdata) * should it be using the interface and enqueuing * frames at this very time on another CPU. */ - synchronize_rcu(); + rcu_barrier(); /* Wait for RX path and call_rcu()'s */ skb_queue_purge(&sdata->u.mesh.skb_queue); }