From patchwork Fri Jun 26 20:45:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 29205 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id B9DA4B7092 for ; Sat, 27 Jun 2009 06:45:52 +1000 (EST) Received: by ozlabs.org (Postfix) id AF479DDDA0; Sat, 27 Jun 2009 06:45:52 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4AD63DDD1C for ; Sat, 27 Jun 2009 06:45:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753740AbZFZUpr (ORCPT ); Fri, 26 Jun 2009 16:45:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751618AbZFZUpq (ORCPT ); Fri, 26 Jun 2009 16:45:46 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:34385 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbZFZUpp (ORCPT ); Fri, 26 Jun 2009 16:45:45 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 5EB08163839; Fri, 26 Jun 2009 22:45:48 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id 42D2545C068; Fri, 26 Jun 2009 22:45:48 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 1/5] bridge: Use rcu_barrier() instead of syncronize_net() on unload. To: "David S. Miller" Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer Date: Fri, 26 Jun 2009 22:45:48 +0200 Message-ID: <20090626204548.10664.75094.stgit@localhost> In-Reply-To: <20090626204152.10664.69628.stgit@localhost> References: <20090626204152.10664.69628.stgit@localhost> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When unloading modules that uses call_rcu() callbacks, then we must use rcu_barrier(). This module uses syncronize_net() which is not enough to be sure that all callback has been completed. Acked-by: Paul E. McKenney Signed-off-by: Jesper Dangaard Brouer --- net/bridge/br.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/bridge/br.c b/net/bridge/br.c index 9aac521..e1241c7 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -93,7 +93,7 @@ static void __exit br_deinit(void) unregister_pernet_subsys(&br_net_ops); - synchronize_net(); + rcu_barrier(); /* Wait for completion of call_rcu()'s */ br_netfilter_fini(); #if defined(CONFIG_ATM_LANE) || defined(CONFIG_ATM_LANE_MODULE)