Message ID | 20090620200438.b5443520.lk-netdev@lk-netdev.nosense.org |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index 6f479fa..07f0f90 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -1092,8 +1092,10 @@ static int econet_rcv(struct sk_buff *skb, struct net_device *dev, struct packet goto drop; if (ec_queue_packet(sk, skb, edev->net, hdr->src_stn, hdr->cb, - hdr->port)) - goto drop; + hdr->port)) { + kfree_skb(skb); + return NET_RX_BAD; + } return 0;
econet_rcv() calls ec_queue_packet(). The return from ec_queue_packet() is the direct result of a call to sock_queue_rcv_skb(). Error returns from ec_queue_packet() and therefore sock_queue_rcv_skb() are due to kernel errors, so have econet_rcv() return NET_RX_BAD in this case. If my understanding is correct, then Signed-off-by: Mark Smith <markzzzsmith@yahoo.com.au> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html