From patchwork Thu Jun 11 03:50:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subrata Modak X-Patchwork-Id: 28544 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 9AF34B7233 for ; Thu, 11 Jun 2009 13:51:09 +1000 (EST) Received: by ozlabs.org (Postfix) id 8AD67DDD0C; Thu, 11 Jun 2009 13:51:09 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 87829DDD0B for ; Thu, 11 Jun 2009 13:51:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757931AbZFKDuy (ORCPT ); Wed, 10 Jun 2009 23:50:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756988AbZFKDux (ORCPT ); Wed, 10 Jun 2009 23:50:53 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:58579 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754783AbZFKDuw (ORCPT ); Wed, 10 Jun 2009 23:50:52 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5B3oFM8017974; Wed, 10 Jun 2009 21:50:15 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5B3osgj248572; Wed, 10 Jun 2009 21:50:54 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5B3oro1021306; Wed, 10 Jun 2009 21:50:54 -0600 Received: from subratamodak.linux.ibm.com ([9.77.213.68]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n5B3olXG021161; Wed, 10 Jun 2009 21:50:49 -0600 From: Subrata Modak To: netdev@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Linuxppc-dev Cc: Sachin P Sant , Linux-Kernel , Linux-Next , Stephen Rothwell , Subrata Modak , Balbir Singh Date: Thu, 11 Jun 2009 09:20:46 +0530 Message-Id: <20090611035046.22125.26641.sendpatchset@subratamodak.linux.ibm.com> Subject: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Benjamin/Paul, >On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote: >CC drivers/net/lance.o > drivers/net/lance.c: In function 'lance_probe1': > drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus' > drivers/net/lance.c: In function 'lance_rx': > drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' > make[2]: *** [drivers/net/lance.o] Error 1 > make[1]: *** [drivers/net] Error 2 > make: *** [drivers] Error 2 Reference: http://lkml.org/lkml/2009/6/4/240, To fix the following build error: drivers/net/lance.c: In function 'lance_probe1': drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus' drivers/net/lance.c: In function 'lance_rx': drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' make[2]: *** [drivers/net/lance.o] Error 1 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 I would like to propose the following patch. The prototypes for the functions: 'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to introduce the following soultion for powerpc ? It fixes the build problem i reported earlier. Signed-off-by: Subrata Modak --- --- Regards-- Subrata -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.30-rc8/arch/powerpc/include/asm/io.h.orig 2009-06-10 21:56:49.000000000 -0500 +++ linux-2.6.30-rc8/arch/powerpc/include/asm/io.h 2009-06-10 22:21:35.000000000 -0500 @@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig #define mmio_outsw(addr, src, count) writesw(addr, src, count) #define mmio_outsl(addr, src, count) writesl(addr, src, count) +#define isa_virt_to_bus virt_to_phys +#define isa_bus_to_virt phys_to_virt + /** * virt_to_phys - map virtual addresses to physical * @address: address to remap