From patchwork Thu Jun 11 02:13:19 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Subrata Modak X-Patchwork-Id: 28537 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 297D6B74B9 for ; Thu, 11 Jun 2009 12:13:38 +1000 (EST) Received: by ozlabs.org (Postfix) id 17863DDD0C; Thu, 11 Jun 2009 12:13:38 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 78C24DDD04 for ; Thu, 11 Jun 2009 12:13:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757173AbZFKCNZ (ORCPT ); Wed, 10 Jun 2009 22:13:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755618AbZFKCNZ (ORCPT ); Wed, 10 Jun 2009 22:13:25 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:58544 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873AbZFKCNY (ORCPT ); Wed, 10 Jun 2009 22:13:24 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e3.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5B28XNe011649; Wed, 10 Jun 2009 22:08:33 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5B2DQXX172262; Wed, 10 Jun 2009 22:13:26 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5B2BBWH029005; Wed, 10 Jun 2009 22:11:12 -0400 Received: from subratamodak.linux.ibm.com ([9.77.215.59]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n5B2B6lC028873; Wed, 10 Jun 2009 22:11:07 -0400 From: Subrata Modak To: michael@ellerman.id.au, netdev@vger.kernel.org, Li Yang , Stephen Rothwell Cc: Sachin P Sant , Linux-Next , Linux-Kernel , Subrata Modak , Balbir Singh , Linuxppc-dev Date: Thu, 11 Jun 2009 07:43:19 +0530 Message-Id: <20090611021319.12649.84902.sendpatchset@subratamodak.linux.ibm.com> Subject: [PATCH][Resend][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Michael, >On Thu, 2009-06-11 at 12:03 +1000, Michael Ellerman wrote: >On Thu, 2009-06-11 at 07:26 +0530, Subrata Modak wrote: > > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: > > > Hi Subrata, > > > > > > On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak wrote: > > > > > > > > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > > > > - ph = of_get_property(np, "tbi-handle", NULL); > > > > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); > > > > > > You don't need this cast because of_get_property() returns "void *". > > > > Stephen, > > > > True. But without this gcc complains: > > > > CC [M] drivers/net/ucc_geth.o > > drivers/net/ucc_geth.c: In function ‘ucc_geth_probe’: > > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers from pointer target type > ^^^^^^^^^^^ > > And what does that warning actually mean? > > Your cast actually introduces a bug. > Ok fine. Here is a revised patch. Subject: [PATCH][Resend][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Reference(s): http://lkml.org/lkml/2009/6/4/241, http://lkml.org/lkml/2009/6/10/338, Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak --- --- Regards-- Subrata > cheers -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 20:53:25.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL;