From patchwork Wed Jun 10 17:43:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subrata Modak X-Patchwork-Id: 28484 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id B51DEB741B for ; Thu, 11 Jun 2009 03:43:52 +1000 (EST) Received: by ozlabs.org (Postfix) id 9B31DDDDF0; Thu, 11 Jun 2009 03:43:52 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 3DD33DDDE6 for ; Thu, 11 Jun 2009 03:43:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759871AbZFJRna (ORCPT ); Wed, 10 Jun 2009 13:43:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758008AbZFJRna (ORCPT ); Wed, 10 Jun 2009 13:43:30 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:47027 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756024AbZFJRn2 (ORCPT ); Wed, 10 Jun 2009 13:43:28 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e7.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5AHVQEI030162; Wed, 10 Jun 2009 13:31:26 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5AHhVR4253462; Wed, 10 Jun 2009 13:43:31 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5AHhUA9018771; Wed, 10 Jun 2009 13:43:30 -0400 Received: from subratamodak.linux.ibm.com ([9.77.215.59]) by d01av03.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n5AHhOX8018620; Wed, 10 Jun 2009 13:43:26 -0400 From: Subrata Modak To: netdev@vger.kernel.org, Li Yang Cc: Sachin P Sant , Stephen Rothwell , Linux-Next , Linux-Kernel , Subrata Modak , Balbir Singh , Linuxppc-dev Date: Wed, 10 Jun 2009 23:13:23 +0530 Message-Id: <20090610174323.28045.70169.sendpatchset@subratamodak.linux.ibm.com> Subject: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Ling, >On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote: >CC [M] drivers/net/ucc_geth.o > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) > make[2]: *** [drivers/net/ucc_geth.o] Error 1 With the above build error reported on 4th June linux next tree, i am proposing the following patch. Can you please let me know if you would like to merge it. Reference: http://lkml.org/lkml/2009/6/4/241, Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak --- --- Regards-- Subrata -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 12:37:15.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL; @@ -3819,7 +3821,7 @@ static int ucc_geth_probe(struct of_devi ugeth->node = np; /* Find the TBI PHY. If it's not there, we don't support SGMII */ - ph = of_get_property(np, "tbi-handle", NULL); + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); if (ph) { struct device_node *tbi = of_find_node_by_phandle(*ph); struct of_device *ofdev;