From patchwork Mon Jun 8 13:11:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 28229 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 6DB31B70AB for ; Mon, 8 Jun 2009 23:11:53 +1000 (EST) Received: by ozlabs.org (Postfix) id 6059FDDDA0; Mon, 8 Jun 2009 23:11:53 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DCA77DDDA1 for ; Mon, 8 Jun 2009 23:11:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801AbZFHNLo (ORCPT ); Mon, 8 Jun 2009 09:11:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754167AbZFHNLn (ORCPT ); Mon, 8 Jun 2009 09:11:43 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:59265 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753801AbZFHNLm (ORCPT ); Mon, 8 Jun 2009 09:11:42 -0400 Received: from hotlava.cxnet.dk (unknown [172.31.4.152]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id D77EA163832; Mon, 8 Jun 2009 15:11:43 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by hotlava.cxnet.dk (Postfix) with ESMTP id CF2B945C068; Mon, 8 Jun 2009 15:11:43 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 4/5] sctp: protocol.c call rcu_barrier() on unload. To: "David S. Miller" Cc: Jesper Dangaard Brouer , "Paul E. McKenney" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, wg@grandegger.com, vladislav.yasevich@hp.com, sri@us.ibm.com, linux-sctp@vger.kernel.org, Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, netfilter-devel@vger.kernel.org Date: Mon, 08 Jun 2009 15:11:43 +0200 Message-ID: <20090608131143.10052.96470.stgit@localhost> In-Reply-To: <20090608130959.10052.54590.stgit@localhost> References: <20090608130959.10052.54590.stgit@localhost> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On module unload call rcu_barrier(), this is needed as synchronize_rcu() is not strong enough. The kmem_cache_destroy() does invoke synchronize_rcu() but it does not provide same protection. Signed-off-by: Jesper Dangaard Brouer Acked-by: Vlad Yasevich --- net/sctp/protocol.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index cb2c50d..79cbd47 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -1370,6 +1370,8 @@ SCTP_STATIC __exit void sctp_exit(void) sctp_proc_exit(); cleanup_sctp_mibs(); + rcu_barrier(); /* Wait for completion of call_rcu()'s */ + kmem_cache_destroy(sctp_chunk_cachep); kmem_cache_destroy(sctp_bucket_cachep); }