From patchwork Mon May 11 11:46:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyrill Gorcunov X-Patchwork-Id: 27048 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 68556B7043 for ; Mon, 11 May 2009 22:54:53 +1000 (EST) Received: by ozlabs.org (Postfix) id 59A7CDDE16; Mon, 11 May 2009 22:54:53 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id F05E2DDE45 for ; Mon, 11 May 2009 22:54:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758072AbZEKMyJ (ORCPT ); Mon, 11 May 2009 08:54:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755482AbZEKMyH (ORCPT ); Mon, 11 May 2009 08:54:07 -0400 Received: from rv-out-0506.google.com ([209.85.198.235]:25787 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756652AbZEKMx5 (ORCPT ); Mon, 11 May 2009 08:53:57 -0400 Received: by rv-out-0506.google.com with SMTP id f9so2140704rvb.1 for ; Mon, 11 May 2009 05:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:message-id :user-agent:date:from:to:cc:subject:references:content-disposition; bh=OkjnKtBY3eMbnhHAkoyV0yeAKAzKjEz6OpkoRFCEg1g=; b=ocBd241Ks5856Uixq6JJOVVXGIDH4hdr9f3X6OGIedsMpEE5lQsb+Q3cuX8iP2ZiJD bdunKNCrmxnI/Kmr8sSG61lBfKKD88hDQMXPINIyyKJgtmX7nj3/S/GiwK22wTs9Zsuz CXeQq7pwEpsJMazQA9Y9sb/ucWS/CR57VN+9M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:user-agent:date:from:to:cc:subject:references :content-disposition; b=JY1ADiS08oPBG1S/0Qqj5aPl7cXh10XWgCv9ojLTToywbHxWiet0QPjF3GBnbqLFb1 teSR53e06WNJhuEhZVLyCnWgEk8TMBm+qToQfJ5crfRdvtQT3ICsjFGGuURfKATJAmKw b+5UxRRoUcE54BwHpoiJDPz/LX5P91a3w9Jsc= Received: by 10.141.185.10 with SMTP id m10mr1051770rvp.195.1242046437177; Mon, 11 May 2009 05:53:57 -0700 (PDT) Received: from gorcunov (95-28-135-248.broadband.corbina.ru [95.28.135.248]) by mx.google.com with ESMTPS id g31sm11071889rvb.13.2009.05.11.05.53.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 11 May 2009 05:53:56 -0700 (PDT) Received: by gorcunov (Postfix, from userid 1000) id C33F85D3; Mon, 11 May 2009 16:53:50 +0400 (MSD) Message-Id: <20090511125350.555985895@openvz.org> User-Agent: quilt/0.47-1 Date: Mon, 11 May 2009 15:46:40 +0400 From: Cyrill Gorcunov To: Stephen Hemminger Cc: davem@davemloft.net, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, xemul@openvz.org, Cyrill Gorcunov Subject: [RFC 1/5] net: bridge - use is_multicast_ether_addr helper References: <20090511114639.440944109@openvz.org> Content-Disposition: inline; filename=net-br-use-is_multicast Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Instead of handwritten constrcution it's better to use is_multicast_ether_addr. Signed-off-by: Cyrill Gorcunov Acked-by: Stephen Hemminger --- net/bridge/br_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6.git/net/bridge/br_device.c ===================================================================== --- linux-2.6.git.orig/net/bridge/br_device.c +++ linux-2.6.git/net/bridge/br_device.c @@ -32,7 +32,7 @@ int br_dev_xmit(struct sk_buff *skb, str skb_reset_mac_header(skb); skb_pull(skb, ETH_HLEN); - if (dest[0] & 1) + if (is_multicast_ether_addr(dest)) br_flood_deliver(br, skb); else if ((dst = __br_fdb_get(br, dest)) != NULL) br_deliver(dst->dst, skb);