From patchwork Wed Apr 15 08:48:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KOSAKI Motohiro X-Patchwork-Id: 25976 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 1DB1FDE1A7 for ; Wed, 15 Apr 2009 18:48:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758823AbZDOIsT (ORCPT ); Wed, 15 Apr 2009 04:48:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758754AbZDOIsR (ORCPT ); Wed, 15 Apr 2009 04:48:17 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:46842 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758080AbZDOIsO (ORCPT ); Wed, 15 Apr 2009 04:48:14 -0400 Received: from mt1.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n3F8mCZP029344 (envelope-from kosaki.motohiro@jp.fujitsu.com); Wed, 15 Apr 2009 17:48:13 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 96C6345DE52; Wed, 15 Apr 2009 17:48:12 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 703D745DE50; Wed, 15 Apr 2009 17:48:12 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 552521DB803F; Wed, 15 Apr 2009 17:48:12 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id D686D1DB803E; Wed, 15 Apr 2009 17:48:08 +0900 (JST) Received: from m105.css.fujitsu.com (m105 [127.0.0.1]) by m105.s.css.fujitsu.com (Postfix) with ESMTP id 997B35D8010; Wed, 15 Apr 2009 17:48:08 +0900 (JST) Received: from [127.0.0.1] (unknown [10.124.100.179]) by m105.s.css.fujitsu.com (Postfix) with ESMTP id D078E5D8011; Wed, 15 Apr 2009 17:48:07 +0900 (JST) From: KOSAKI Motohiro To: Nick Piggin Subject: Re: [RFC][PATCH v3 6/6] fix wrong get_user_pages usage in iovlock.c Cc: kosaki.motohiro@jp.fujitsu.com, LKML , Linus Torvalds , Andrew Morton , Andrea Arcangeli , Jeff Moyer , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Maciej Sosnowski , "David S. Miller" , Chris Leech , netdev@vger.kernel.org In-Reply-To: <20090414155719.C66B.A69D9226@jp.fujitsu.com> References: <200904141656.14191.nickpiggin@yahoo.com.au> <20090414155719.C66B.A69D9226@jp.fujitsu.com> Message-Id: <20090415174658.AC4F.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 X-Mailer: Becky! ver. 2.50 [ja] Date: Wed, 15 Apr 2009 17:48:07 +0900 (JST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > I would perhaps not fold gup_fast conversions into the same patch as > > the fix. > > OK. I'll fix. Done. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html =================================== Subject: [Untested][RFC][PATCH] fix wrong get_user_pages usage in iovlock.c down_read(mmap_sem) get_user_pages() up_read(mmap_sem) is fork unsafe. fix it. Signed-off-by: KOSAKI Motohiro Cc: Maciej Sosnowski Cc: David S. Miller Cc: Chris Leech Cc: netdev@vger.kernel.org --- drivers/dma/iovlock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/dma/iovlock.c =================================================================== --- a/drivers/dma/iovlock.c 2009-04-13 22:58:36.000000000 +0900 +++ b/drivers/dma/iovlock.c 2009-04-14 20:27:16.000000000 +0900 @@ -104,8 +104,6 @@ struct dma_pinned_list *dma_pin_iovec_pa 0, /* force */ page_list->pages, NULL); - up_read(¤t->mm->mmap_sem); - if (ret != page_list->nr_pages) goto unpin; @@ -127,6 +125,8 @@ void dma_unpin_iovec_pages(struct dma_pi if (!pinned_list) return; + up_read(¤t->mm->mmap_sem); + for (i = 0; i < pinned_list->nr_iovecs; i++) { struct dma_page_list *page_list = &pinned_list->page_list[i]; for (j = 0; j < page_list->nr_pages; j++) {