From patchwork Sat Jan 17 07:19:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Brownell X-Patchwork-Id: 19093 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 80427DE26E for ; Sat, 17 Jan 2009 18:19:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754885AbZAQHTw (ORCPT ); Sat, 17 Jan 2009 02:19:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754760AbZAQHTv (ORCPT ); Sat, 17 Jan 2009 02:19:51 -0500 Received: from smtp128.sbc.mail.sp1.yahoo.com ([69.147.65.187]:27218 "HELO smtp128.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750903AbZAQHTv (ORCPT ); Sat, 17 Jan 2009 02:19:51 -0500 Received: (qmail 14734 invoked from network); 17 Jan 2009 07:19:50 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=58f5PjzkXt+krs+gEH0u2zDzZlDaxH0JCeMqyW46uNSBICNhxqaea7SS/t6O2u88lGvrC5co/W2nxnaQG7ciwTcK6ox+0r2X4qNoM20lnQTp1GCMOq+P5TEOX2IldmxGl6pYh0r1h98y0QbmckSHBzQuqXrH+gTuQGA7DmaVL7A= ; Received: from unknown (HELO pogo) (david-b@69.226.224.20 with plain) by smtp128.sbc.mail.sp1.yahoo.com with SMTP; 17 Jan 2009 07:19:50 -0000 X-YMail-OSG: HJ648_MVM1lbDW5XJ8EpXN1ZkNo9.TDBQfomx_zakJSWNXn6IlU_xAaRfQLTaWovraOJ6l9ZX56hHzumPwGMdVfwipO1GDT.2WMdohf04SAVvKOPHz7cTrpa4H6t5EOQYcYQ2xfJZpXT1ZLWtvtR.2qtakPeWTan_bns5vc9DV9A2DZXhLdUS9s6qXWUH3KTEdzghr1_e7reJwKHRxTYmuXaQrug X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: netdev@vger.kernel.org Subject: [patch 2.6.29-rc] usbnet: allow type check of devdbg arguments in non-debug build Date: Fri, 16 Jan 2009 23:19:44 -0800 User-Agent: KMail/1.9.10 Cc: Steve Glendinning , Ian Saturley , Jeff Garzik References: <1221493664-544-1-git-send-email-steve.glendinning@smsc.com> In-Reply-To: <1221493664-544-1-git-send-email-steve.glendinning@smsc.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200901162319.44255.david-b@pacbell.net> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Steve Glendinning Subject: usbnet: allow type check of devdbg arguments in non-debug build Improve usbnet's devdbg to always type-check diagnostic arguments, like dev_dbg (device.h). This makes no change to the resulting size of usbnet modules. Signed-off-by: Steve Glendinning Signed-off-by: David Brownell --- [ refreshed against 2.6.29-rc1 GIT ] include/linux/usb/usbnet.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/include/linux/usb/usbnet.h +++ b/include/linux/usb/usbnet.h @@ -197,7 +197,9 @@ extern int usbnet_nway_reset(struct net_ #define devdbg(usbnet, fmt, arg...) \ printk(KERN_DEBUG "%s: " fmt "\n" , (usbnet)->net->name , ## arg) #else -#define devdbg(usbnet, fmt, arg...) do {} while(0) +#define devdbg(usbnet, fmt, arg...) \ + ({ if (0) printk(KERN_DEBUG "%s: " fmt "\n" , (usbnet)->net->name , \ + ## arg); 0; }) #endif #define deverr(usbnet, fmt, arg...) \