From patchwork Tue Nov 25 16:32:50 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arjan van de Ven X-Patchwork-Id: 10657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 58336DDED9 for ; Wed, 26 Nov 2008 03:31:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbYKYQbv (ORCPT ); Tue, 25 Nov 2008 11:31:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751189AbYKYQbu (ORCPT ); Tue, 25 Nov 2008 11:31:50 -0500 Received: from casper.infradead.org ([85.118.1.10]:58438 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbYKYQbu convert rfc822-to-8bit (ORCPT ); Tue, 25 Nov 2008 11:31:50 -0500 Received: from c-71-193-193-226.hsd1.or.comcast.net ([71.193.193.226] helo=localhost.localdomain) by casper.infradead.org with esmtpsa (Exim 4.69 #1 (Red Hat Linux)) id 1L50pI-0007Lu-He for netdev@vger.kernel.org; Tue, 25 Nov 2008 16:31:49 +0000 Date: Tue, 25 Nov 2008 08:32:50 -0800 From: Arjan van de Ven To: netdev@vger.kernel.org Subject: [PATCH] net: make skb_truesize_bug() call WARN() Message-ID: <20081125083250.2ad7d75d@infradead.org> Organization: Intel X-Mailer: Claws Mail 3.6.0 (GTK+ 2.14.4; i386-redhat-linux-gnu) Mime-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From 97a8ab520c378568e172c555a156b469137a3828 Mon Sep 17 00:00:00 2001 From: Arjan van de Ven Date: Tue, 25 Nov 2008 08:30:04 -0800 Subject: [PATCH] net: make skb_truesize_bug() call WARN() The truesize message check is important enough to make it print "BUG" to the user console... lets also make it important enough to spit a backtrace/module list etc so that kerneloops.org can track them. Signed-off-by: Arjan van de Ven --- net/core/skbuff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 391be91..1a1f4d1 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -149,7 +149,7 @@ void skb_under_panic(struct sk_buff *skb, int sz, void *here) void skb_truesize_bug(struct sk_buff *skb) { - printk(KERN_ERR "SKB BUG: Invalid truesize (%u) " + WARN(1, KERN_ERR "SKB BUG: Invalid truesize (%u) " "len=%u, sizeof(sk_buff)=%Zd\n", skb->truesize, skb->len, sizeof(struct sk_buff)); }