From patchwork Tue Nov 11 22:21:48 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. K. Cliburn" X-Patchwork-Id: 8205 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D5C12DDDF3 for ; Wed, 12 Nov 2008 09:22:03 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbYKKWV4 (ORCPT ); Tue, 11 Nov 2008 17:21:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753869AbYKKWVz (ORCPT ); Tue, 11 Nov 2008 17:21:55 -0500 Received: from rv-out-0506.google.com ([209.85.198.229]:48213 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbYKKWVy (ORCPT ); Tue, 11 Nov 2008 17:21:54 -0500 Received: by rv-out-0506.google.com with SMTP id k40so104486rvb.1 for ; Tue, 11 Nov 2008 14:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:x-mailer:mime-version:content-type :content-transfer-encoding; bh=+g9a6O8eQpZMmpDpwu8fnRg5t45yGjIXh9tDCr6+plA=; b=XmhUDIYpY3YfQ+ish6EG7R+8ZGL62R/Xof1jL/novqKZhQyVeDj9iotWUNIPjy6CG4 pQqVK5CVBahUi9SYACkMRcLSinM29Cv8tZEJbXyi/KiDLT+ZzcazFaOffy6VUpX7lHEa PwWYsY2Vo8H/xoEoqqq3+9JNi99Hwz0QfjvrE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; b=LDa6rW1plQH1saYP5+FFl4WywKPl9+r+iDlQb/0ZIg6Ec3ygPDFKAx0o94meUJdwHQ 2HTMvOcJ9bGPXoFB7fwTKvAOP5b4rqXjkZeGMxSpVzgcmrFX9RinbMjPXEnJ1pydERWp AaPy5NgvcRMAU/C2T5hMyiTBWAiYCmwgZwBkY= Received: by 10.143.35.4 with SMTP id n4mr3190706wfj.177.1226442113842; Tue, 11 Nov 2008 14:21:53 -0800 (PST) Received: from osprey.hogchain.net ([70.152.123.69]) by mx.google.com with ESMTPS id 32sm14850124wfa.8.2008.11.11.14.21.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 11 Nov 2008 14:21:52 -0800 (PST) Date: Tue, 11 Nov 2008 16:21:48 -0600 From: "J. K. Cliburn" To: jeff@garzik.org Cc: netdev@vger.kernel.org, Chris Snook , jie.yang@atheros.com, David Madore Subject: [PATCH] atl1e: remove unnecessary crc inversion Message-ID: <20081111162148.5b56db58@osprey.hogchain.net> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org atl1e: remove unnecessary crc inversion Inverting the crc after calling ether_crc_le() is unnecessary and breaks multicast. Remove it. Tested-by: David Madore Signed-off-by: Jay Cliburn Cc: stable@kernel.org --- drivers/net/atl1e/atl1e_hw.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/atl1e/atl1e_hw.c b/drivers/net/atl1e/atl1e_hw.c index 949e753..c0d5f7c 100644 --- a/drivers/net/atl1e/atl1e_hw.c +++ b/drivers/net/atl1e/atl1e_hw.c @@ -163,9 +163,6 @@ int atl1e_read_mac_addr(struct atl1e_hw *hw) * atl1e_hash_mc_addr * purpose * set hash value for a multicast address - * hash calcu processing : - * 1. calcu 32bit CRC for multicast address - * 2. reverse crc with MSB to LSB */ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr) { @@ -174,7 +171,6 @@ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr) int i; crc32 = ether_crc_le(6, mc_addr); - crc32 = ~crc32; for (i = 0; i < 32; i++) value |= (((crc32 >> i) & 1) << (31 - i));