From patchwork Tue Nov 11 16:08:16 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. K. Cliburn" X-Patchwork-Id: 8157 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 1D571474ED for ; Wed, 12 Nov 2008 03:08:46 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753001AbYKKQIZ (ORCPT ); Tue, 11 Nov 2008 11:08:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752914AbYKKQIY (ORCPT ); Tue, 11 Nov 2008 11:08:24 -0500 Received: from wf-out-1314.google.com ([209.85.200.168]:17865 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbYKKQIW (ORCPT ); Tue, 11 Nov 2008 11:08:22 -0500 Received: by wf-out-1314.google.com with SMTP id 27so3249803wfd.4 for ; Tue, 11 Nov 2008 08:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type:content-transfer-encoding; bh=Qyu9gSNJGXRPwWUjh1vGLrf9d6kfouAVFhKHAGoxJ/0=; b=en8+6JdaK5/uSxGmbm1wnR2w+19cfKRP5ALKqoOGALR1Tk/QnLtTpW72bxjHGD/wZ6 bCRxr/gz14Z/QnIsHO7fJ2ObYDHZJTuvJsneLNlzX6IdFsKpt2KO//UKwKPuYjgSqYWC OoUxhmCkosapDZ1XdIW3EU6Znptq9fEWtiLms= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=IgEqaVSdhvRTCp+MdVRodbttiqSlCCK7OqYGK2S+OF9pciDgVEdKObf+0iKB4QNv9k QOp4Bc6O7S5TSS9KGZ6V2y/mMh6TmGvX4is6o3PcMXvhD0Z58BoEvONZy05U74rpZEu/ k5KWYGX1WvsNv/pA5mE/5FUP8tXgFBcb6M+TQ= Received: by 10.142.142.14 with SMTP id p14mr3041267wfd.94.1226419701100; Tue, 11 Nov 2008 08:08:21 -0800 (PST) Received: from osprey.hogchain.net ([70.152.123.69]) by mx.google.com with ESMTPS id 22sm13504222wfd.7.2008.11.11.08.08.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 11 Nov 2008 08:08:20 -0800 (PST) Date: Tue, 11 Nov 2008 10:08:16 -0600 From: "J. K. Cliburn" To: David Madore Cc: Linux Kernel Mailing-List , Linux NetDev Mailing-List , atl1-devel@lists.sourceforge.net Subject: Re: atl1e Ethernet driver not seeing packets sent to 33:33:00:00:00:01 multicast Message-ID: <20081111100816.58a7cf09@osprey.hogchain.net> In-Reply-To: <20081111155908.GA14665@clipper.ens.fr> References: <20081111133108.GA7124@clipper.ens.fr> <20081111080611.7f6d4371@osprey.hogchain.net> <20081111155908.GA14665@clipper.ens.fr> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 11 Nov 2008 16:59:08 +0100 David Madore wrote: > On Tue, Nov 11, 2008 at 08:06:11AM -0600, J. K. Cliburn wrote: > > Just to verify your system is fitted with the L1e and not the L1 > > chip, can you please provide the output of lspci -vvnn? > > Here goes (adapter in question is at the very end): Thanks. Can you please try this patch? diff --git a/drivers/net/atl1e/atl1e_hw.c b/drivers/net/atl1e/atl1e_hw.c index 949e753..c0d5f7c 100644 --- a/drivers/net/atl1e/atl1e_hw.c +++ b/drivers/net/atl1e/atl1e_hw.c @@ -163,9 +163,6 @@ int atl1e_read_mac_addr(struct atl1e_hw *hw) * atl1e_hash_mc_addr * purpose * set hash value for a multicast address - * hash calcu processing : - * 1. calcu 32bit CRC for multicast address - * 2. reverse crc with MSB to LSB */ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr) { @@ -174,7 +171,6 @@ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr) int i; crc32 = ether_crc_le(6, mc_addr); - crc32 = ~crc32; for (i = 0; i < 32; i++) value |= (((crc32 >> i) & 1) << (31 - i));