From patchwork Tue Nov 4 11:11:18 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan McDowell X-Patchwork-Id: 7083 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B93D1DDDF3 for ; Tue, 4 Nov 2008 22:11:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbYKDLLV (ORCPT ); Tue, 4 Nov 2008 06:11:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752527AbYKDLLU (ORCPT ); Tue, 4 Nov 2008 06:11:20 -0500 Received: from the.earth.li ([217.147.81.2]:47327 "EHLO the.earth.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbYKDLLU (ORCPT ); Tue, 4 Nov 2008 06:11:20 -0500 Received: from noodles by the.earth.li with local (Exim 4.63) (envelope-from ) id 1KxJod-0000D0-00; Tue, 04 Nov 2008 11:11:19 +0000 Date: Tue, 4 Nov 2008 11:11:18 +0000 From: Jonathan McDowell To: netdev@vger.kernel.org Cc: Marcel Holtmann Subject: [PATCH] hso should register as a WWAN rfkill device, not WLAN Message-ID: <20081104111118.GQ3162@earth.li> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently the hso driver registers a WLAN rfkill switch, which is intended for 802.11 wireless network devices. Given that this driver supports GSM/HSPA devices it's more appropriate to register a WWAN rfkill switch type. Signed-Off-By: Jonathan McDowell ----- ----- J. diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 1164c52..3f49e83 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -2188,7 +2188,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev, char *rfkn; hso_net->rfkill = rfkill_allocate(&interface_to_usbdev(interface)->dev, - RFKILL_TYPE_WLAN); + RFKILL_TYPE_WWAN); if (!hso_net->rfkill) { dev_err(dev, "%s - Out of memory\n", __func__); return;