From patchwork Tue Jul 23 12:38:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Wu X-Patchwork-Id: 261068 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 783F92C00B6 for ; Tue, 23 Jul 2013 22:38:55 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757043Ab3GWMiw (ORCPT ); Tue, 23 Jul 2013 08:38:52 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:46069 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760Ab3GWMiv (ORCPT ); Tue, 23 Jul 2013 08:38:51 -0400 Received: by mail-ee0-f43.google.com with SMTP id l10so4446394eei.2 for ; Tue, 23 Jul 2013 05:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=n8b4SXUnhiC6IjGsk/jtrjRJRlABRSRWOqn3h4qkxnw=; b=iilOcebZ5/ctqanLX90mcd+nwDlSFFcnRQUjbbaxs43sJ+nEX8QkIECCyyydi9/T8R aXxlAprRdBOV9z2So/S1cNAyfvIKhW3o9P9EgUDS0iuaSz3sB1F5jbmEjjeTbdKpvPSf 5jXUk6Rtl6+Bj24U/dscoa6Xa7sL8KS03TrrhmNsZxhHPThvq5uMH9R36qZlsMj5a8LD DmZQfDO2EANy7duPAeLugx7e7MIz85lLqZ5E7kPrplR/fH7FXzYlEFudeqIyuJVailvc wKuwqSeNDlU2cDjL1mqS2nIGosTzwK7zyi0EJXjbdEDisOzcFiz+01+T4FgrX3Np8MQK 6VBQ== X-Received: by 10.15.49.9 with SMTP id i9mr31884155eew.69.1374583129930; Tue, 23 Jul 2013 05:38:49 -0700 (PDT) Received: from al.localnet (al.lekensteyn.nl. [2001:470:1f15:b83::c0d1:f1ed]) by mx.google.com with ESMTPSA id i2sm58432236eeu.4.2013.07.23.05.38.47 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Jul 2013 05:38:49 -0700 (PDT) From: Peter Wu To: Sergei Shtylyov Cc: Francois Romieu , David Miller , netdev@vger.kernel.org, nic_swsd@realtek.com Subject: [PATCH v2] r8169: remove "PHY reset until link up" log spam Date: Tue, 23 Jul 2013 14:38:46 +0200 Message-ID: <1765554.SGJMeyexPP@al> User-Agent: KMail/4.10.5 (Linux/3.10.0-1-custom; KDE/4.10.5; x86_64; ; ) In-Reply-To: <51EE75A1.3070804@cogentembedded.com> References: <4961229.bXDGvH0dpz@al> <51EE75A1.3070804@cogentembedded.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This message was added in commit a7154cb8 (June 2004, [PATCH] r8169: link handling and phy reset rework) and is printed every ten seconds when no cable is connected. (Before that commit, "Reset RTL8169s PHY" would be printed instead.) Signed-off-by: Peter Wu --- On Tuesday 23 July 2013 16:22:57 Sergei Shtylyov wrote: > On 23-07-2013 13:55, Peter Wu wrote: > > This message was added in commit a7154cb8 (June 2004) and is printed > > Please also specify that commit's summary line in parens. Done, while at it I have also noted that an other spam message would be logged. --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) if (tp->link_ok(ioaddr)) return; - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); - tp->phy_reset_enable(tp); out_mod_timer: