| Message ID | 1604405100-33255-1-git-send-email-zou_wei@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] dpaa_eth: use false and true for bool variables | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Guessed tree name to be net-next |
| jkicinski/subject_prefix | warning | Target tree name not specified in the subject |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
> -----Original Message----- > From: Zou Wei <zou_wei@huawei.com> > Sent: 03 November 2020 14:05 > To: Madalin Bucur <madalin.bucur@nxp.com>; davem@davemloft.net; > kuba@kernel.org > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zou Wei > <zou_wei@huawei.com> > Subject: [PATCH -next] dpaa_eth: use false and true for bool variables > > Fix coccicheck warnings: > > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > index d9c2859..31407c1 100644 > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv > *priv) > for_each_online_cpu(i) { > percpu_priv = per_cpu_ptr(priv->percpu_priv, i); > > - percpu_priv->np.down = 0; > + percpu_priv->np.down = false; > napi_enable(&percpu_priv->np.napi); > } > } > @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv > *priv) > for_each_online_cpu(i) { > percpu_priv = per_cpu_ptr(priv->percpu_priv, i); > > - percpu_priv->np.down = 1; > + percpu_priv->np.down = true; > napi_disable(&percpu_priv->np.napi); > } > } > -- > 2.6.2 Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
On Tue, 3 Nov 2020 12:13:29 +0000 Madalin Bucur wrote: > > Fix coccicheck warnings: > > > > ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable > > ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > > Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com> Applied, thanks!
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index d9c2859..31407c1 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv *priv) for_each_online_cpu(i) { percpu_priv = per_cpu_ptr(priv->percpu_priv, i); - percpu_priv->np.down = 0; + percpu_priv->np.down = false; napi_enable(&percpu_priv->np.napi); } } @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv *priv) for_each_online_cpu(i) { percpu_priv = per_cpu_ptr(priv->percpu_priv, i); - percpu_priv->np.down = 1; + percpu_priv->np.down = true; napi_disable(&percpu_priv->np.napi); } }
Fix coccicheck warnings: ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)