| Message ID | 1587732746-98057-1-git-send-email-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,v2] ptp: clockmatrix: remove unnecessary comparison | expand |
>Reported-by: Hulk Robot <hulkci@huawei.com> >Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >--- > drivers/ptp/ptp_clockmatrix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c >index 032e112..56aee4f 100644 >--- a/drivers/ptp/ptp_clockmatrix.c >+++ b/drivers/ptp/ptp_clockmatrix.c >@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm, > > /* Page size 128, last 4 bytes of page skipped */ > if (((loaddr > 0x7b) && (loaddr <= 0x7f)) >- || ((loaddr > 0xfb) && (loaddr <= 0xff))) >+ || loaddr > 0xfb) > continue; > > err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val)); Thank-you for the fix. Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
From: Yang Yingliang <yangyingliang@huawei.com> Date: Fri, 24 Apr 2020 20:52:26 +0800 > The type of loaddr is u8 which is always '<=' 0xff, so the > loaddr <= 0xff is always true, we can remove this comparison. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Applied.
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index 032e112..56aee4f 100644 --- a/drivers/ptp/ptp_clockmatrix.c +++ b/drivers/ptp/ptp_clockmatrix.c @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm, /* Page size 128, last 4 bytes of page skipped */ if (((loaddr > 0x7b) && (loaddr <= 0x7f)) - || ((loaddr > 0xfb) && (loaddr <= 0xff))) + || loaddr > 0xfb) continue; err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));
The type of loaddr is u8 which is always '<=' 0xff, so the loaddr <= 0xff is always true, we can remove this comparison. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/ptp/ptp_clockmatrix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)