| Message ID | 1578967276-55956-4-git-send-email-boon.leong.ong@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: stmmac: general fixes for Ethernet functionality | expand |
On Tue, 14 Jan 2020 10:01:12 +0800, Ong Boon Leong wrote: Please fix the date on your system. Please always provide a patch description. For bug fixes description of how the bug manifest to the users is important to have. > Fixes: d2afb5bdffde ("stmmac: fix the rx csum feature") > Please remove the empty lines between the Fixes tag and the other tags on all patches. > Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index cd55d16..dc739cd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -3911,6 +3911,8 @@ static int stmmac_set_features(struct net_device *netdev, > for (chan = 0; chan < priv->plat->rx_queues_to_use; chan++) > stmmac_enable_sph(priv, priv->ioaddr, sph_en, chan); > > + netdev->features = features; > + > return 0; > } >
>On Tue, 14 Jan 2020 10:01:12 +0800, Ong Boon Leong wrote: > >Please fix the date on your system. > >Please always provide a patch description. For bug fixes description of >how the bug manifest to the users is important to have. > >> Fixes: d2afb5bdffde ("stmmac: fix the rx csum feature") >> > >Please remove the empty lines between the Fixes tag and the other tags >on all patches. Thanks for input. Will fix.
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index cd55d16..dc739cd 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3911,6 +3911,8 @@ static int stmmac_set_features(struct net_device *netdev, for (chan = 0; chan < priv->plat->rx_queues_to_use; chan++) stmmac_enable_sph(priv, priv->ioaddr, sph_en, chan); + netdev->features = features; + return 0; }
Fixes: d2afb5bdffde ("stmmac: fix the rx csum feature") Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+)