diff mbox series

net: Remove redundant BUG_ON() check in phonet_pernet

Message ID 1578043240-35541-1-git-send-email-vulab@iscas.ac.cn
State Accepted
Delegated to: David Miller
Headers show
Series net: Remove redundant BUG_ON() check in phonet_pernet | expand

Commit Message

Xu Wang Jan. 3, 2020, 9:20 a.m. UTC 
Passing NULL to phonet_pernet causes a crash via BUG_ON.
Dereferencing net in net_generic() also has the same effect.
This patch removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 net/phonet/pn_dev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Miller Jan. 3, 2020, 8:26 p.m. UTC | #1 
From: Xu Wang <vulab@iscas.ac.cn>
Date: Fri,  3 Jan 2020 09:20:40 +0000

> Passing NULL to phonet_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generic() also has the same effect.
> This patch removes the redundant BUG_ON check on the same parameter.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Applied.
diff mbox series

Patch

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index 49bd76a..ac0fae0 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -35,8 +35,6 @@  static unsigned int phonet_net_id __read_mostly;
 
 static struct phonet_net *phonet_pernet(struct net *net)
 {
-	BUG_ON(!net);
-
 	return net_generic(net, phonet_net_id);
 }