| Message ID | 1577180224-16405-1-git-send-email-vulab@iscas.ac.cn |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | ppp: Remove redundant BUG_ON() check in ppp_pernet | expand |
Hello! On 12/24/2019 12:37 PM, Xu Wang wrote: > Passing NULL to ppp_pernet causes a crash via BUG_ON. > Dereferencing net in net_generici() also has the same effect. s/generici/generic/. :-) > This patch removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> [...] MBR, Sergei
From: Xu Wang <vulab@iscas.ac.cn> Date: Tue, 24 Dec 2019 09:37:04 +0000 > Passing NULL to ppp_pernet causes a crash via BUG_ON. > Dereferencing net in net_generici() also has the same effect. > This patch removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Applied, thanks.
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index 3bf8a8b..22cc2cb 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -296,8 +296,6 @@ static struct class *ppp_class; /* per net-namespace data */ static inline struct ppp_net *ppp_pernet(struct net *net) { - BUG_ON(!net); - return net_generic(net, ppp_net_id); }
Passing NULL to ppp_pernet causes a crash via BUG_ON. Dereferencing net in net_generici() also has the same effect. This patch removes the redundant BUG_ON check on the same parameter. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- drivers/net/ppp/ppp_generic.c | 2 -- 1 file changed, 2 deletions(-)